From owner-freebsd-current Sun Nov 24 23:02:01 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id XAA08592 for current-outgoing; Sun, 24 Nov 1996 23:02:01 -0800 (PST) Received: from GndRsh.aac.dev.com (GndRsh.aac.dev.com [198.145.92.241]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id XAA08587 for ; Sun, 24 Nov 1996 23:01:56 -0800 (PST) Received: (from rgrimes@localhost) by GndRsh.aac.dev.com (8.7.5/8.7.3) id WAA02033; Sun, 24 Nov 1996 22:56:08 -0800 (PST) From: "Rodney W. Grimes" Message-Id: <199611250656.WAA02033@GndRsh.aac.dev.com> Subject: Re: 2.2-ALPHA install failure In-Reply-To: <4977.848903584@time.cdrom.com> from "Jordan K. Hubbard" at "Nov 24, 96 10:33:04 pm" To: jkh@time.cdrom.com (Jordan K. Hubbard) Date: Sun, 24 Nov 1996 22:56:08 -0800 (PST) Cc: phk@critter.tfs.com, joerg_wunsch@uriah.heep.sax.de, freebsd-current@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL25 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-current@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk > > >If you're referring to the sysinstall code, it's because you *told* > > >me to set it to that in the DD case as a hint to libdisk. Maybe > > >I should have wrapped the arguments around a brick first? :-) > > > > >I< most certainly didn't tell you. > > I wish I had a recording, but I hate to tell you that you really > really did. Back when the DD stuff came in, I asked you "hey, Poul, > in the DD case what the heck should I set the geometry to?" and you > said "how about 1 for everything?" > > So I did. Believe me, I didn't just make it up on my own - I've never > professed to have any idea about the proper care and feeding of > geometries, just as you've proclaimed a lack of knowledge/interest in > GUI design, and I'm just following orders here. :-) > > In any case, rather than pointing fingers I'd just as soon make it > DTRT, but I'm still waiting for input on what TRT is. :-) I've got some data on TRT... but first I just found a few small bugs in fdisk that should really be fixed, like bad formats for output data that casued my 2^32-1 sector disk to report -1 as it's size :-). The NCR controller gets along just fine with (though the kernel complains about slice size != raw part size): SkyRsh# fdisk sd2 ******* Working on device /dev/rsd2 ******* parameters extracted from in-core disklabel are: cylinders=4341 heads=64 sectors/track=32 (2048 blks/cyl) Figures below won't work with BIOS for partitions not in cyl 1 parameters to be used for BIOS calculations are: cylinders=4341 heads=64 sectors/track=32 (2048 blks/cyl) Warning: BIOS sector numbering starts with sector 1 Information from DOS bootblock is: The data for partition 0 is: The data for partition 1 is: The data for partition 2 is: The data for partition 3 is: sysid 165,(FreeBSD/NetBSD/386BSD) start 0, size -1 (2097151 Meg), flag 80 beg: cyl 0/ sector 1/ head 0; end: cyl 1023/ sector 32/ head 63 SkyRsh# (Note, above is buggy version of the code, after my patch it reports correctly, I'm just booted from my other system disk to send this mail...) While I was in there I did a -Wall -Wformat cleanup, though it seems that -Wformat does not report signed vs unsigned errors, it didn't miss the undeclared function declarations... :-( Could someone review this and I'll go commit it to -current. Index: fdisk.c =================================================================== RCS file: /home/ncvs/src/sbin/i386/fdisk/fdisk.c,v retrieving revision 1.12 diff -u -r1.12 fdisk.c --- fdisk.c 1996/11/06 14:08:39 1.12 +++ fdisk.c 1996/11/25 06:47:36 @@ -24,6 +24,9 @@ * the rights to redistribute these changes. */ +#include +#include +#include #include #include #include @@ -431,7 +434,7 @@ return; } printf("sysid %d,(%s)\n", partp->dp_typ, get_type(partp->dp_typ)); - printf(" start %ld, size %ld (%ld Meg), flag %x\n", + printf(" start %lu, size %lu (%lu Meg), flag %x\n", partp->dp_start, partp->dp_size, partp->dp_size * 512 / (1024 * 1024), partp->dp_flag); @@ -1103,8 +1106,8 @@ break; } fprintf(stderr, - "%s: WARNING: adjusting start offset of partition '%d' from %d\n\ - to %d, to round to an head boundary.\n", + "%s: WARNING: adjusting start offset of partition '%d' from %lu\n\ + to %lu, to round to an head boundary.\n", name, partition, partp->dp_start, adj_size); partp->dp_start = adj_size; } @@ -1119,7 +1122,7 @@ if (adj_size != partp->dp_size) { fprintf(stderr, - "%s: WARNING: adjusting size of partition '%d' from %d to %d,\n\ + "%s: WARNING: adjusting size of partition '%d' from %lu to %lu,\n\ to round to a cylinder boundary.\n", name, partition, partp->dp_size, adj_size); if (chunks > 0) -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation, Inc. Reliable computers for FreeBSD