Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Apr 2011 10:24:34 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Rick Macklem <rmacklem@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r221205 - head/sys/fs/nfsclient
Message-ID:  <201104291024.34096.jhb@freebsd.org>
In-Reply-To: <201104291230.p3TCUFOR099081@svn.freebsd.org>
References:  <201104291230.p3TCUFOR099081@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, April 29, 2011 8:30:15 am Rick Macklem wrote:
> Author: rmacklem
> Date: Fri Apr 29 12:30:15 2011
> New Revision: 221205
> URL: http://svn.freebsd.org/changeset/base/221205
> 
> Log:
>   The build was broken by r221190 for 64bit arches like amd64.
>   This patch fixes it.
>   
>   MFC after:	2 weeks
> 
> Modified:
>   head/sys/fs/nfsclient/nfs_clvfsops.c
> 
> Modified: head/sys/fs/nfsclient/nfs_clvfsops.c

Somewhat related.  It seems the vfs_* API used to process nmount-style
mount options, uses 'int' instead of 'size_t' for all of its 'len'
parameters.  I think this is a bug and that it should be fixed to use
size_t instead.  That would let this change be reverted as 'len' could
always be a size_t in this case.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201104291024.34096.jhb>