From owner-freebsd-hackers@FreeBSD.ORG Sun Mar 15 22:22:40 2009 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 82E161065670 for ; Sun, 15 Mar 2009 22:22:40 +0000 (UTC) (envelope-from mbsd@pacbell.net) Received: from nlpi053.prodigy.net (nlpi053.sbcis.sbc.com [207.115.36.82]) by mx1.freebsd.org (Postfix) with ESMTP id 54F188FC14 for ; Sun, 15 Mar 2009 22:22:40 +0000 (UTC) (envelope-from mbsd@pacbell.net) Received: from antec (adsl-99-22-94-30.dsl.pltn13.sbcglobal.net [99.22.94.30]) (authenticated bits=0) by nlpi053.prodigy.net (8.13.8 smtpauth/dk/map_regex/8.13.8) with ESMTP id n2FMMaJr020954; Sun, 15 Mar 2009 17:22:37 -0500 Date: Sun, 15 Mar 2009 15:22:37 -0700 (PDT) From: =?ISO-8859-1?Q?Mikko_Ty=F6l=E4j=E4rvi?= To: Nate Eldredge In-Reply-To: Message-ID: <20090315151836.K24160@antec.home> References: <49BA9E63.3040000@smartt.com> <20090315144440.N24160@antec.home> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="738249620-1902150241-1237155757=:24160" Cc: freebsd-hackers@freebsd.org, Chris St Denis Subject: Re: Bug in tcp wrappers? X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Mar 2009 22:22:40 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --738249620-1902150241-1237155757=:24160 Content-Type: TEXT/PLAIN; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8BIT On Sun, 15 Mar 2009, Nate Eldredge wrote: > On Sun, 15 Mar 2009, Mikko Työläjärvi wrote: > >> The real fix involves rewriting chunks of the libwrap code, or finding >> a version where someone has already done so. > > It doesn't seem like it should be too bad. xgets is only called in three > places. It would be easy enough to replace it with something like glibc's > getline(3), that uses realloc to size a buffer appropriately. Yes, it should be pretty straightforward. I just noticed that openbsd applied a (better) variant of my patch for the infinite loop problem in 2003. They didn't address the "line too long" problem, though. > If nobody else feels like doing this, maybe I will. And if you don't, I just might :) /Mikko --738249620-1902150241-1237155757=:24160--