From owner-freebsd-current@FreeBSD.ORG Fri Nov 16 23:18:38 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0EDC516A417 for ; Fri, 16 Nov 2007 23:18:38 +0000 (UTC) (envelope-from pawel.worach@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.169]) by mx1.freebsd.org (Postfix) with ESMTP id 88AE813C442 for ; Fri, 16 Nov 2007 23:18:37 +0000 (UTC) (envelope-from pawel.worach@gmail.com) Received: by ug-out-1314.google.com with SMTP id y2so887815uge for ; Fri, 16 Nov 2007 15:18:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; bh=e887DtSVdly8wGnVhTcwLfnFRiTHoEtXPOSk3FjszxI=; b=CqA8DoJHalZe3xvunZjiuBvqlafFUP/Aybao539JAc1zog/tVdQ9yKQi+L+PMNqNd8GopJTvStfbTmVoEhB/yy7G5y+K4t/JEWbblZFwi8oY31xOtu4uOjs7UVubOrun4fb/M+lMxIxE77D48AH1hdn+0Buv67mwj5uKSvHOwUk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=VEx0hPDBirKCXNMKkSnrA9tkS0lY9tqsV18jC94xufjODMZvKpRrKELfFZCcBbidod1SC1KrdkR+vmgQJ4eiLKt9MUGKCYP+MTh9owX6pagsPGmAFb3Fe8leF8D5f5Wmli+EtoJP0bNXusuk8/YkWfLg8th56e9OhhQA48X1f9c= Received: by 10.66.248.5 with SMTP id v5mr438833ugh.1195255116230; Fri, 16 Nov 2007 15:18:36 -0800 (PST) Received: from ?192.168.10.200? ( [80.216.208.24]) by mx.google.com with ESMTPS id e1sm8513442ugf.2007.11.16.15.18.35 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 16 Nov 2007 15:18:35 -0800 (PST) Message-ID: <473E2545.30504@gmail.com> Date: Sat, 17 Nov 2007 00:18:29 +0100 From: Pawel Worach User-Agent: Thunderbird 2.0.0.7pre (X11/20071106) MIME-Version: 1.0 To: Jung-uk Kim References: <200711161338.54270.jkim@FreeBSD.org> <473E0EA6.1070904@gmail.com> <200711161801.53513.jkim@FreeBSD.org> In-Reply-To: <200711161801.53513.jkim@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-acpi@FreeBSD.org, freebsd-current@FreeBSD.org Subject: Re: [Call for Testers] ACPI-CA 20071114 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2007 23:18:38 -0000 Jung-uk Kim wrote: > On Friday 16 November 2007 04:41 pm, Pawel Worach wrote: >> Jung-uk Kim wrote: >>> Please test the following patch on -CURRENT: >>> >>> http://people.freebsd.org/~jkim/acpica-import-20071114.diff.gz >> Hi, >> >> Looks good here on a ThinkPad T60 except for a new LOR. >> >> acpi_ibm0: on acpi0 >> lock order reversal: (sleepable after non-sleepable) >> 1st 0xc083cb00 LED mtx (LED mtx) @ /usr/src/sys/dev/led/led.c:263 >> 2nd 0xc09cc304 ACPI IBM extras (ACPI IBM extras) @ >> /usr/src/sys/modules/acpi/acpi_ibm/../../../dev/acpi_support/acpi_i >> bm.c:311 KDB: stack backtrace: > > --- >8 --- SKIP --- >8 --- > > I have to admit that I haven't really tested anything under > sys/dev/acpi_support because I don't own any of these laptops. :-( > Anyway, can you test the following? > > --- sys/dev/acpi_support/acpi_ibm.c 25 Oct 2007 17:30:18 -0000 > +++ sys/dev/acpi_support/acpi_ibm.c 16 Nov 2007 22:43:39 -0000 > @@ -300,7 +300,7 @@ > sc->led_busy = 1; > sc->led_state = onoff; > > - AcpiOsExecute(OSL_NOTIFY_HANDLER, (void *)ibm_led_task, sc); > + acpi_queue_task(OSL_NOTIFY_HANDLER, (void *)ibm_led_task, sc); > } > > static void > Yes, that fixed the LOR, thanks! -- Pawel