From nobody Wed Oct 1 13:49:37 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ccGWS6Qqrz69fbw; Wed, 01 Oct 2025 13:49:40 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ccGWS5sRQz43FV; Wed, 01 Oct 2025 13:49:40 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759326580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7MjEax5XYWBRJf00E4gejdYJ1d8Wyi2d0E0k2w0f1FM=; b=eYb8/P05BECkSWx8qFnv2yAd6JGdp4ZDiSyR+Smf9y9+Y9QyAgTtJLNbhrsS4//9EJWR4D w1mJspJ3Bi1uWttp1EJCkibrB63KzmvAwewDIB6kF6AB3uMD1NpaXNAPIC593474mIwLWG YfeVcCVFwHcxS782sB80Gv9wtPHzuGwAATrvibp2SSJRwkWext9JT72r/+ap6FV5Km/3Xv /FJho/ewuJ5oG9IMNH1bQDuSFuXMZvFK7chelKu7euTW+aY6p41qlJiZSIzhNXc2pZ67if uSAwEZ7MCzVMDZ+GxajPYCTw47SMjM1jfc3w744GFUzi0lAxKHeOIVnlyfI/5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759326580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7MjEax5XYWBRJf00E4gejdYJ1d8Wyi2d0E0k2w0f1FM=; b=gtpJ45UXPHuAnKkHEWnmmR273R/j10GdNGW6b3JGSMUjxXXqgH8E6esURO8QL2gPRJ8+8f L7maurmJXgBVeVU4V2jNyrBjSM/AtedRJOiESANyQAPlKTuAmKFJ191/v6cd2z9WOzhfX2 8GP5syci3VX8VE4fCW2iuuYsc2mz+FF6ISm/rmUojb87tFOEX1d3g6W6G16waNO6Tu4XL4 yYLFy9/MNy8Mz8vX7mA3IgW2On+RFW3qJ8KVOm5yKuJGJcqL6/gR/nkkg9t9kLSKfmhAOh tlWPNQECC736o3SGFnm6P4aP2y2mUOXgAu++U8vXDYXnuzZ5Ns9MYxXwp3v2RA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759326580; a=rsa-sha256; cv=none; b=ZYZrtLhxdwD6wDkvfW5xqzzTTO79aFHczeG1pSySg7DOfJsnk2kIRCGXg6UMADFQgDAKXm hEVvR9D1WCUiyiTLHrtRgLdbiI8l/D+2xERJFtmqXJP7OqnFU6h7yz1cTb+1KYfU6kjev5 ZDpYr5E9dpKVNoDQhPdO8CvUp8kOUoOvBglFB8JapO2XgGpJbx9f5jlDTcpq2CvnqNfZlb Z0RRSm0saEa1YU0ysA9XNJVe5KyGLuN5DNLd6+AZtAoVLzOZVHcQ7xxHGiqGffS7uCA3GE y6KROly4A3MBLdIWFNZwPimcN0IDzsW+EBI0Uz0czsbgyUGWHNk72yu2njtSxQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ccGWS0R5pzBQj; Wed, 01 Oct 2025 13:49:39 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Wed, 1 Oct 2025 06:49:37 -0700 From: Gleb Smirnoff To: Kevin Irabor Cc: Kristof Provost , ItzBlinkzy , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4e7a375804e5 - main - IfAPI: Added missing accessor for if_home_vnet Message-ID: References: <202509292116.58TLGxWx078766@gitrepo.freebsd.org> <9E63C594-08DD-43CD-BD76-3E9B9E80AA60@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Oct 01, 2025 at 09:27:05AM +0100, Kevin Irabor wrote: K> Hello, K> Both emails are mine - one I use as my GitHub email and the one I signed K> off with is my personal email. Sorry for the confusion there. K> To answer your questions: K> I was browsing the ifnet code and saw the earlier IfAPI commits that were K> made. I assumed the pattern was to provide accessors for every field in K> struct ifnet, and to maintain consistency I added this one since it was K> missing. K> I'm not aware of any drivers that need if_home_vnet and if_vmove Thanks Kevin! I'd suggest to revert the change as we don't expect any driver to ever use this field. And if one uses, that would be a problem. If you want to help with current state of IfAPI, then there is a task to categorize the existing accessors into few groups: - those that all NIC drivers use - those that a few NIC drivers use - those that in-stack drivers (e.g. vlan(4), lagg(4), etc) use - those that no one uses A minimal documentation (a comment in the source code) with the results of this categorization will be helpful. And jumping forward, I would suggest to remove the accessors that belong to class 4 - no one uses. -- Gleb Smirnoff