From owner-svn-src-head@FreeBSD.ORG  Wed Apr  1 12:13:47 2015
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id DD3F6899;
 Wed,  1 Apr 2015 12:13:47 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 62B73315;
 Wed,  1 Apr 2015 12:13:46 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t31CDiav058321
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 1 Apr 2015 15:13:44 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t31CDium058320;
 Wed, 1 Apr 2015 15:13:44 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 1 Apr 2015 15:13:44 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Mateusz Guzik <mjguzik@gmail.com>
Subject: Re: svn commit: r280955 - in head/sys: modules/notrandom dev/notrandom
Message-ID: <20150401121344.GC64665@FreeBSD.org>
References: <20150401113628.GA16649@dft-labs.eu>
 <20150401114313.GZ64665@FreeBSD.org>
 <20150401115204.GB16649@dft-labs.eu>
 <20150401115729.GA64665@FreeBSD.org>
 <20150401120229.GA2201@dft-labs.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150401120229.GA2201@dft-labs.eu>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Apr 2015 12:13:48 -0000

  Mateusz,

On Wed, Apr 01, 2015 at 02:02:29PM +0200, Mateusz Guzik wrote:
M> > You can add the seven_region variable to dev/null/null.c and implement
M> > the new device here. Now notrandom.c shares > 50% of code with null.c.
M> 
M> Yeah I know, in fact I got most of the code from that driver.
M> 
M> I just wanted to have a file with my own copyright in the tree, what's
M> so bad about it.
M> 
M> If you feel strongly about it feel free to move it, but I would prefer
M> if you did not.

You are increasing size of kernel object file merely for a selfish reason.

While some systems do not care about kernel object size, some embedded do.
Size of source code also matters. You added new code in FreeBSD, that
is likely to be supported for a long time. Of course maintaing two files,
where one is paste of other, requires more efforts than maintaining
single file.

Mateusz, if you keep the momentum, in the next years we will see lots
of files with your copyright. :) There is no reason to create one
just for this. Also, you can legitimately add your name into header of
null.c if you move code of notrandom there.

-- 
Totus tuus, Glebius.