From owner-svn-src-head@freebsd.org  Wed May 11 20:43:42 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7A39B37A41;
 Wed, 11 May 2016 20:43:42 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com
 [IPv6:2607:f8b0:4001:c06::22b])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A38351108;
 Wed, 11 May 2016 20:43:42 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: by mail-io0-x22b.google.com with SMTP id 190so70211165iow.1;
 Wed, 11 May 2016 13:43:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc;
 bh=qeCJ5iOEIrxMDWIZVJNLEbLk4xtFTYx0gGMqRQCzhQw=;
 b=Ha+QD+1m/Dl2xNu88K5CN+9AjPxPrTmqE7/AVQ9v1X9bKc98e7D9CsDJ9kphE1wNIh
 fKhn7kAHDgBHAWUXQ1tV61D8m1bGG5NYzRB2IegOmt6IRdVuoQvC+PF47G1twj/iMTjV
 nesxKsfUOBH3IPPnNHfSqIi77Langp1myJ8cxGk58DKBHUZPpt0/GnL4IiHQliIY1A5e
 HtOKbvm75hR7KNBvjSaH6+6qFSTYqdVFZBU0iBzolJmTShMJGn2Aej05LSXcsL++jpoe
 V8KGkxRGYgBQAU1koWrsgtBM/8Ex2xG8ELRXFECB3jWvMMUDL0VCpwCo26mrh+kNYr85
 sjSA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
 :date:message-id:subject:to:cc;
 bh=qeCJ5iOEIrxMDWIZVJNLEbLk4xtFTYx0gGMqRQCzhQw=;
 b=Q7HAjAh4+kp4kx67Vv9UPr2z6+6fpgT2iG8CRidqyl+kmVBV+Ay4FDtdUzkGK8+TLb
 dGbQn2vl/sPKKmwFtsiOjT80W9NkEal39H5QdoI0nGtDAyj7UIKgS2JH9X2Hfq+eTum6
 XLjYa8vbxIC0APaKKGwFcky6V19lqKZhUcyBga6YD0CNBYyZoElU7gesrqH6vzFZH2BJ
 K/hiGa0KLYCZMbBFYMu2fsqTcXnEtMlNnINnj/p80zkpkvyywJk3kpLLfZH1w4wK9p7X
 owOLmiZ6jNLWq69HWTUghN1fozGKT+hhRHTve3wcT7dCgJ06j+gE4a00lhSFPnaW7QO+
 0NeA==
X-Gm-Message-State: AOPr4FXM7/5toFBKk9yaCCAWXReZqZ61M/aqfn8DZkIBsEVMCrvPN0CTGND4i76Lrt5yj1CbyhUR2h8LKBWrHg==
X-Received: by 10.107.159.84 with SMTP id i81mr4753175ioe.29.1462999422132;
 Wed, 11 May 2016 13:43:42 -0700 (PDT)
MIME-Version: 1.0
Sender: carpeddiem@gmail.com
Received: by 10.107.27.197 with HTTP; Wed, 11 May 2016 13:43:22 -0700 (PDT)
In-Reply-To: <201605112006.u4BK6NNd095917@repo.freebsd.org>
References: <201605112006.u4BK6NNd095917@repo.freebsd.org>
From: Ed Maste <emaste@freebsd.org>
Date: Wed, 11 May 2016 16:43:22 -0400
X-Google-Sender-Auth: dP62qdcHrSoQ0U1EmKfpeYOXFIw
Message-ID: <CAPyFy2DFrykypD7WVyJpd_hVw64ynRD0rtXwJoZn6OScba9ULg@mail.gmail.com>
Subject: Re: svn commit: r299480 - head/secure/lib/libcrypto
To: Jung-uk Kim <jkim@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 May 2016 20:43:42 -0000

On 11 May 2016 at 16:06, Jung-uk Kim <jkim@freebsd.org> wrote:
> Author: jkim
> Date: Wed May 11 20:06:23 2016
> New Revision: 299480
> URL: https://svnweb.freebsd.org/changeset/base/299480
>
[...]
>         ( echo '# $$'FreeBSD'$$' ;\
>         echo '# Do not modify. This file is auto-generated from ${.IMPSRC:T}.' ;\
>         echo '#ifdef PIC' ;\
> -       perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} -fpic -DPIC ;\
> +       env CC=cc perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} -fpic -DPIC ;\
>         echo '#else' ;\
> -       perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} ;\
> +       env CC=cc perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} ;\

One thing that occurred to me in the older PIC change here: perhaps we
should explicitly strip -fpic / -DPIC from the passed-in ${CFLAGS} for
the #else. It's unlikely, but possible, that a user could regenerate
the assembly files with -fpic set in CFLAGS.