From owner-freebsd-net@FreeBSD.ORG Sun Oct 24 09:55:46 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C3C8E106564A; Sun, 24 Oct 2010 09:55:46 +0000 (UTC) (envelope-from freebsd-listen@fabiankeil.de) Received: from smtprelay03.ispgateway.de (smtprelay03.ispgateway.de [80.67.18.15]) by mx1.freebsd.org (Postfix) with ESMTP id 4F85F8FC12; Sun, 24 Oct 2010 09:55:46 +0000 (UTC) Received: from [78.34.145.129] (helo=r500.local) by smtprelay03.ispgateway.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1P9x3J-00069h-GI; Sun, 24 Oct 2010 11:39:48 +0200 Date: Sun, 24 Oct 2010 11:39:43 +0200 From: Fabian Keil To: Max Laier Message-ID: <20101024113943.3cc0d659@r500.local> In-Reply-To: <4CC3C5C9.7040904@laiers.net> References: <4CC3C5C9.7040904@laiers.net> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; amd64-portbld-freebsd9.0) X-PGP-KEY-URL: http://www.fabiankeil.de/gpg-keys/freebsd-listen-2008-08-18.asc Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/svSC+F=4tHHhCo+JTSVJg5H"; protocol="application/pgp-signature" X-Df-Sender: 775067 Cc: Ermal =?ISO-8859-1?Q?Lu=E7i?= , freebsd-net , freebsd-pf@freebsd.org Subject: Re: [PATCH] pf(4) patch from OpenBSD 4.5 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Oct 2010 09:55:46 -0000 --Sig_/svSC+F=4tHHhCo+JTSVJg5H Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Max Laier wrote: > C'mon ... where are the testers at? >=20 > On 18.10.2010 11:10, Ermal Lu=E7i wrote: > > Feedback is very welcome. >=20 > Is there no-one testing Ermal's exciting patch? Let's help getting this= =20 > tested ... before we put it into SVN! >=20 > fetch http://people.freebsd.org/~eri/pf45_1.diff > patch -p1 < pf45_1.diff I think that should be -p0. > make buildworld buildkernel > etc. ... >=20 > Let's go!!! And do not forget to reply if it works just, too. I got a bunch of rejections: fk@r500 /usr/src $patch -C -p0 < /home/fk/test/freebsd/pf45_1.diff 2>&1 | g= rep .rej 1 out of 6 hunks failed--saving rejects to contrib/pf/pfctl/pfctl_table.c.r= ej 1 out of 114 hunks failed--saving rejects to contrib/pf/pfctl/parse.y.rej 1 out of 37 hunks failed--saving rejects to contrib/pf/pfctl/pfctl.c.rej 1 out of 4 hunks failed--saving rejects to contrib/pf/pfctl/pfctl_parser.h.= rej 1 out of 15 hunks failed--saving rejects to contrib/pf/pfctl/pfctl.8.rej 1 out of 6 hunks failed--saving rejects to contrib/pf/pfctl/pfctl.h.rej 1 out of 56 hunks failed--saving rejects to sys/contrib/pf/net/pf_norm.c.rej 1 out of 16 hunks failed--saving rejects to sys/contrib/pf/net/if_pflog.c.r= ej 1 out of 15 hunks failed--saving rejects to sys/contrib/pf/net/pf_osfp.c.rej They can be fixed by running the files through perl -i'' -pe 's@\$FreeBSD[^\$]+\$@\$FreeBSD\$@' * before applying the patch. Afterwards the patch applies cleanly. However the build still fails for me: /usr/obj/usr/src/make.amd64/make -V CFILES -V SYSTEM_CFILES -V GEN_CFILES |= MKDEP_CPP=3D"cc -E" CC=3D"cc" xargs mkdep -a -f .newdep -O2 -frename-regi= sters -pipe -fno-strict-aliasing -std=3Dc99 -g -Wall -Wredundant-decls -Wn= ested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wi= nline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc = -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfi= lter -I/usr/src/sys/contrib/pf -I/usr/src/sys/dev/ath -I/usr/src/sys/dev/at= h/ath_hal -I/usr/src/sys/contrib/ngatm -I/usr/src/sys/dev/twa -I/usr/src/sy= s/gnu/fs/xfs/FreeBSD -I/usr/src/sys/gnu/fs/xfs/FreeBSD/support -I/usr/src/s= ys/gnu/fs/xfs -I/usr/src/sys/contrib/opensolaris/compat -I/usr/src/sys/dev/= cxgb -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-comm= on -finline-limit=3D8000 --param inline-unit-growth=3D100 --param large-fun= ction-growth=3D1000 -fno-omit-frame-pointer -mcmodel=3Dkernel -mno-red-zon= e -mfpmath=3D387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow -msoft-= float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector /usr/src/sys/contrib/pf/net/pf.c:149:26: error: net/if_pflow.h: No such fil= e or directory mkdep: compile failed *** Error code 1 Stop in /usr/obj/usr/src/sys/ZOEY. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. I'm using HEAD from yesterday and if_pflow.h indeed doesn't seem to exist. Fabian --Sig_/svSC+F=4tHHhCo+JTSVJg5H Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iEYEARECAAYFAkzD/uQACgkQBYqIVf93VJ3jLQCgqUP61qe9WF0zBD2XbiCbnF76 +zAAn1zPE43YCnXL1+M9tTp5fcyyoCw0 =jEYJ -----END PGP SIGNATURE----- --Sig_/svSC+F=4tHHhCo+JTSVJg5H--