From owner-svn-src-head@FreeBSD.ORG Sun Mar 29 14:09:59 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0750F106566C for ; Sun, 29 Mar 2009 14:09:59 +0000 (UTC) (envelope-from unixmania@gmail.com) Received: from mail-bw0-f164.google.com (mail-bw0-f164.google.com [209.85.218.164]) by mx1.freebsd.org (Postfix) with ESMTP id 84D298FC1A for ; Sun, 29 Mar 2009 14:09:58 +0000 (UTC) (envelope-from unixmania@gmail.com) Received: by bwz8 with SMTP id 8so1511056bwz.43 for ; Sun, 29 Mar 2009 07:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=DGXhc1ypBWIFOF6KU4HTcN9HgOuWem06VgfVumAU6+Q=; b=pfbTRLrhzIs3I7kb/i4vb1Us6H3g/s9uy79FMYJMvYHuDBZwYTMzGv4+/f63x/U7Lv npZwZbNQ6/lp41Xp3AjLXH61QGuY+mpahEZJqNvtTwe85FrM/piiZKgxJg7eXsGTCcgJ 7A42V2NPNLmZ8D/XHc3iGdTUtAzA7X7eLLJJs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=ZNB/LC29+dfowX27c0gbuSnZQ8lOYzeVxMbalYuinfDypRjZTnFJyr0koYfVLllc+V UNC+mnpT26JsYshVUeIBZldooC45UXUL1cGhwv+vlUIky58WTANSVo+KJVQyq3x9Xhqt akLNqr5rjjn/oN2yybxq45erHcUFyNFeMH7j0= MIME-Version: 1.0 Received: by 10.103.243.9 with SMTP id v9mr1229176mur.91.1238334192516; Sun, 29 Mar 2009 06:43:12 -0700 (PDT) In-Reply-To: <200903270317.n2R3HPR6046525@svn.freebsd.org> References: <200903270317.n2R3HPR6046525@svn.freebsd.org> Date: Sun, 29 Mar 2009 10:43:12 -0300 Message-ID: From: "Carlos A. M. dos Santos" To: Juli Mallett Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r190458 - head/sys/dev/wpi X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Mar 2009 14:09:59 -0000 On Fri, Mar 27, 2009 at 12:17 AM, Juli Mallett wrote: > Author: jmallett > Date: Fri Mar 27 03:17:25 2009 > New Revision: 190458 > URL: http://svn.freebsd.org/changeset/base/190458 > > Log: > o) Check that no overrun or CRC errors were encountered in receiving a > packet. Linux, OpenBSD and our iwn(4) all do this. It also results in > a huge performance improvement (and the rejection of a fair number of > apparently-bad packets on receive) on my hardware. > o) Like the wpi(4) driver in OpenBSD, and like our iwn(4), also drop runt > packets. > o) Don't bother doing IFQ_POLL and then IFQ_DRV_DEQUEUE, just do > IFQ_DRV_DEQUEUE outright. This is more similar to how OpenBSD and our > iwn(4) work. Do you plan to MFC this? -- My preferred quotation of Robert Louis Stevenson is "You cannot make an omelette without breaking eggs". Not because I like the omelettes, but because I like the sound of eggs being broken.