From owner-freebsd-fs@FreeBSD.ORG Thu May 13 07:00:18 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 22C04106566C for ; Thu, 13 May 2010 07:00:18 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (unknown [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id F04448FC18 for ; Thu, 13 May 2010 07:00:17 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o4D70HHU075034 for ; Thu, 13 May 2010 07:00:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o4D70HWQ075033; Thu, 13 May 2010 07:00:17 GMT (envelope-from gnats) Date: Thu, 13 May 2010 07:00:17 GMT Message-Id: <201005130700.o4D70HWQ075033@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: Andriy Gapon Cc: Subject: Re: bin/144214: zfsboot fails on gang block after upgrade to zfs v14 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Andriy Gapon List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 May 2010 07:00:18 -0000 The following reply was made to PR bin/144214; it has been noted by GNATS. From: Andriy Gapon To: bug-followup@FreeBSD.org, c.kworr@gmail.com Cc: Robert Noland Subject: Re: bin/144214: zfsboot fails on gang block after upgrade to zfs v14 Date: Thu, 13 May 2010 09:59:00 +0300 This is a multi-part message in MIME format. --------------010603020208000201000600 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit It seems that I have been misunderstanding the problem. "ZFS: gang block detected" won't even appear if boot code is too old. Having briefly glanced over the code and comparing it to the code in osol and in zio_gang_tree_issue(), I think the following change is needed. But I am not sure if it is a real fix for the issue at hand. If anyone can reproduce the problem, could you please test this change? Thanks! -- Andriy Gapon --------------010603020208000201000600 Content-Type: text/plain; name="zfs-boot-gang.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="zfs-boot-gang.patch" ZGlmZiAtLWdpdCBhL3N5cy9ib290L3pmcy96ZnNpbXBsLmMgYi9zeXMvYm9vdC96ZnMvemZz aW1wbC5jCmluZGV4IGRjMjllMGUuLmVhZTAwMjMgMTAwNjQ0Ci0tLSBhL3N5cy9ib290L3pm cy96ZnNpbXBsLmMKKysrIGIvc3lzL2Jvb3QvemZzL3pmc2ltcGwuYwpAQCAtOTYyLDggKzk2 MiwxMyBAQCB6aW9fcmVhZF9nYW5nKHNwYV90ICpzcGEsIGNvbnN0IGJsa3B0cl90ICpicCwg Y29uc3QgZHZhX3QgKmR2YSwgdm9pZCAqYnVmKQogCQlyZXR1cm4gKEVJTyk7CiAKIAlmb3Ig KGkgPSAwOyBpIDwgU1BBX0dCSF9OQkxLUFRSUzsgaSsrKSB7Ci0JCWlmICh6aW9fcmVhZChz cGEsICZ6aW9fZ2IuemdfYmxrcHRyW2ldLCBidWYpKQorCQlibGtwdHJfdCAqZ2JwID0gJnpp b19nYi56Z19ibGtwdHJbaV07CisKKwkJaWYgKEJQX0lTX0hPTEUoZ2JwKSkKKwkJCWNvbnRp bnVlOworCQlpZiAoemlvX3JlYWQoc3BhLCBnYnAsIGJ1ZikpCiAJCQlyZXR1cm4gKEVJTyk7 CisJCWJ1ZiA9IChjaGFyKilidWYgKyBCUF9HRVRfUFNJWkUoZ2JwKTsKIAl9CiAgCiAJcmV0 dXJuICgwKTsK --------------010603020208000201000600--