From owner-freebsd-gnome@FreeBSD.ORG Fri May 17 01:37:34 2013 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D489F70F for ; Fri, 17 May 2013 01:37:34 +0000 (UTC) (envelope-from mezz.freebsd@gmail.com) Received: from mail-vb0-x232.google.com (mail-vb0-x232.google.com [IPv6:2607:f8b0:400c:c02::232]) by mx1.freebsd.org (Postfix) with ESMTP id 9A4B2AF8 for ; Fri, 17 May 2013 01:37:34 +0000 (UTC) Received: by mail-vb0-f50.google.com with SMTP id w15so744418vbb.37 for ; Thu, 16 May 2013 18:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=wRkqJ33IOosTBq6f+oRgi9bjBLoiSrRElszODejjCnc=; b=gaKSVd9S5jpUv2oAfEwvMET4A6xLriTKxhwTNUIPuds64WgWueh6rQC8ssTrfhagiO 1HIN3nS0F0ZTP5tEvrAr5UF5qblqpXSlkhWa09S/bY40VjZ4BxxESk2vD5stqGcATQFv 9VeLCnCLRd8DSrZbndFRpgOcsJ0c9C5Gvf4TtTifOqCMDq2kq/cD+nYIDvZWJPDww+1a zz5VuqRN9oWbnL7s1JHbvlGHIyz6OUzDFrkiJDcvAKaLtYxvRidyrcJHif35oHHndPxY jkkbpFa53vLqlT7Ta/zlal5AkwPW3uA/NMx65P+P9bLWMMMjRjkmqm7I6XiMV8rbnHrZ ooyQ== MIME-Version: 1.0 X-Received: by 10.58.247.130 with SMTP id ye2mr28971006vec.35.1368754654194; Thu, 16 May 2013 18:37:34 -0700 (PDT) Received: by 10.58.97.130 with HTTP; Thu, 16 May 2013 18:37:34 -0700 (PDT) In-Reply-To: <51952FA5.5010307@tutopia.com> References: <201305150530.r4F5UDxN042667@freefall.freebsd.org> <72f5fb9e17f4fcd3153990f255752633@tutopia.com> <51952FA5.5010307@tutopia.com> Date: Thu, 16 May 2013 20:37:34 -0500 Message-ID: Subject: Re: ports/178552: Update print/freetype2 to version 2.4.12 From: Jeremy Messenger To: Pedro Giffuni Content-Type: text/plain; charset=ISO-8859-1 Cc: FreeBSD GNOME Users X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 May 2013 01:37:34 -0000 On Thu, May 16, 2013 at 2:12 PM, Pedro Giffuni wrote: > On 15.05.2013 13:42, Jeremy Messenger wrote: >> >> On Wed, May 15, 2013 at 11:38 AM, wrote: >>> >>> On Wed, 15 May 2013 07:51:50 -0500, Jeremy Messenger >>> wrote: >>>>> >>>>> Apart from some minor issues, this version of FreeType supports the >>>>> new CFF engine donated by Adobe in collaboration with Google. >>>>> >>>>> Testing of this new feature is encouraged but in order to activate >>>>> it the code must be patched so I added the suggested patch that sets >>>>> it as the new default hinter. >>>> >>>> >>>> >>>> Why did you enable it by default? This is a testing feature and they >>>> must have disable it for some reasons too, so it needs to be disabled >>>> by default with the optional provide. It will be enable by default >>>> when they enable it. We need to follow its tarball's default. >>>> >>> It is simply a very desirable feature, specially if you have >>> Opentype fonts available. >>> >>> They will be enabling it by default on their next release but >>> it is already considered stable enough (it just works here). >> >> The freetype2 is not a port that where you can just throw it quick. >> They didn't enable this now, because it's not ready so the ports tree >> isn't ready for this either. > > > I understand they made this release specifically so people > would give it more testing. > > I just couldn't wait and I enabled it :). > > >>> I think we should at least have an option to enable it. >> >> Yes, it's what I have suggested in my first replied. ;-) > > > Hmm.. the extra patch solved the issue for me but it was > indeed a quick fix. I personally feel little motivation to do > more if it doesn't reflect in the final package though. > > What about adding an option but enabling it by default? ;). > Otherwise I guess we can just close the PR and wait for a > new version. It really does need to be disabled by default. Next time when you create a patch. Please don't use ":" in the name of file. The ports tree doesn't allow it anymore (years ago) only if you add a new file. It needs to be "_" as I believe that it's in the porter handbook. > Pedro. -- mezz.freebsd@gmail.com - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org