Date: Mon, 9 Aug 1999 16:58:14 +1000 From: Bruce Evans <bde@zeta.org.au> To: bde@zeta.org.au, phk@critter.freebsd.dk Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, green@FreeBSD.org Subject: Re: cvs commit: src/libexec/telnetd sys_term.c Message-ID: <199908090658.QAA08926@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>>> Log: >>> Add a missing include (sys/queue.h for sys/tty.h SLIST usage.) >>> >>> Revision Changes Path >>> 1.22 +2 -1 src/libexec/telnetd/sys_term.c >> >>Wrong fix. <sys/queue.h> is not a prerequisite of <sys/tty.h> (recent >>breakage of <sys/tty.h> doesn't count). >Yeah, I think the right fix is to include <sys/queue.h> in ><sys/types.h> and remove all explicit includes to it. This would be 1) nonstandard. POSIX.1 only reserves names ending in _t for <sys/types.h>. 2) bogus. <sys/queue.h> doesn't declare any types. Including <sys/queue.h> in <sys/param.h> would work in the kernel but wouldn't help in applications. There is nothing better than including <sys/queue.h> in all headers that use it. According to my list of prerequisites, this is already done everywhere except <nfs/nfsrvcache.h>. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199908090658.QAA08926>