From owner-freebsd-fs@FreeBSD.ORG Thu Mar 4 07:03:44 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 990BE1065674; Thu, 4 Mar 2010 07:03:44 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) Received: from kabab.cs.huji.ac.il (kabab.cs.huji.ac.il [132.65.16.84]) by mx1.freebsd.org (Postfix) with ESMTP id 385448FC1A; Thu, 4 Mar 2010 07:03:43 +0000 (UTC) Received: from pampa.cs.huji.ac.il ([132.65.80.32]) by kabab.cs.huji.ac.il with esmtp id 1Nn55u-000Ik6-9C; Thu, 04 Mar 2010 09:03:38 +0200 X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2 To: Rick Macklem In-reply-to: References: <20100226174021.8feadad9.gerrit@pmp.uni-hannover.de> <20100226224320.8c4259bf.gerrit@pmp.uni-hannover.de> <4B884757.9040001@digiware.nl> <20100227080220.ac6a2e4d.gerrit@pmp.uni-hannover.de> <4B892918.4080701@digiware.nl> <20100227202105.f31cbef7.gerrit@pmp.uni-hannover.de> <20100227193819.GA60576@icarus.home.lan> <4B89943C.70704@digiware.nl> <20100227220310.GA65110@icarus.home.lan> Comments: In-reply-to Rick Macklem message dated "Wed, 03 Mar 2010 19:39:46 -0500." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 04 Mar 2010 09:03:37 +0200 From: Daniel Braniss Message-ID: Cc: stable@freebsd.org, freebsd-fs@freebsd.org, Willem Jan Withagen , =?utf-8?B?RWlyaWsgw5h2ZXJieQ==?= , rwatson@freebsd.org, Jeremy Chadwick Subject: Re: mbuf leakage with nfs/udp (was mbuf leakage with nfs/zfs?) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Mar 2010 07:03:44 -0000 > > > On Wed, 3 Mar 2010, Daniel Braniss wrote: > > > disabling the krpc reply cache does it, no visible damage. Somehow > > this reminds me of my old 1970 beetle, parts would fall off but it would > > continue working :-) > > where to go from here? > > > Ok, so it sounds like the leak is in the krpc reply cache code, if I > understand this? (ie. you are running the regular server with the reply > cache disabled and the UDP client mounts aren't causing the leak.) correct. The interesting side effect, is that I can't see any negative issues when disabling the cash. > > Good work on tracking this down! > it was a coordinated efford :-) > I guess the next step is to look through the code for the leak. I'll > do that someday, but if anyone else is inspired to do so, they are > more than welcome.:-) > > Thanks for working through this, rick thank you! I have a vested interest in having this fixed, on the other hand nfsd seems ok, I have been running it now on a semi production server and it's holding up quiet nicely, the cache seems not up to expectations: store-mg-03# nfsstat -se Server Info: Getattr Setattr Lookup Readlink Read Write Create Remove 48176764 262687 12582599 19732 4225907 9186574 780793 818837 Rename Link Symlink Mkdir Rmdir Readdir RdirPlus Access 7623 160 27753 59551 59552 118216 0 1992779 Mknod Fsstat Fsinfo PathConf Commit LookupP SetClId SetClIdCf 0 979005 19 0 1644267 0 0 0 Open OpenAttr OpenDwnGr OpenCfrm DelePurge DeleRet GetFH Lock 0 0 0 0 0 0 0 0 LockT LockU Close Verify NVerify PutFH PutPubFH PutRootFH 0 0 0 0 0 0 0 0 Renew RestoreFH SaveFH Secinfo RelLckOwn V4Create 0 0 0 0 0 0 Server: Retfailed Faults Clients 0 0 0 OpenOwner Opens LockOwner Locks Delegs 0 0 0 0 0 Server Cache Stats: Inprog Idem Non-idem Misses CacheSize TCPPeak 307 0 297 80943198 0 0 danny