Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Dec 2023 18:31:59 GMT
From:      Jessica Clarke <jrtc27@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 3812c653b146 - main - Revert "Don't try and run kldxref for arm kernels"
Message-ID:  <202312141831.3BEIVxUQ067256@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by jrtc27:

URL: https://cgit.FreeBSD.org/src/commit/?id=3812c653b1468bc97003c9f59cc13cfd9afb6ed1

commit 3812c653b1468bc97003c9f59cc13cfd9afb6ed1
Author:     Jessica Clarke <jrtc27@FreeBSD.org>
AuthorDate: 2023-12-14 18:27:09 +0000
Commit:     Jessica Clarke <jrtc27@FreeBSD.org>
CommitDate: 2023-12-14 18:27:09 +0000

    Revert "Don't try and run kldxref for arm kernels"
    
    Now that kldxref supports arm this should not be needed.
    
    This reverts commit 0840bdbf2a07b68e29267bc49057ca6df2351360.
---
 sys/conf/kmod.mk     | 3 +--
 sys/modules/Makefile | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/sys/conf/kmod.mk b/sys/conf/kmod.mk
index 4482034baf67..5d4dcd4371bc 100644
--- a/sys/conf/kmod.mk
+++ b/sys/conf/kmod.mk
@@ -354,8 +354,7 @@ _kmodinstall: .PHONY
 
 .include <bsd.links.mk>
 
-# XXX: kldxref lacks support for arm
-.if !defined(NO_XREF) && ${MACHINE_CPUARCH} != "arm"
+.if !defined(NO_XREF)
 afterinstall: _kldxref
 .ORDER: realinstall _kldxref
 .ORDER: _installlinks _kldxref
diff --git a/sys/modules/Makefile b/sys/modules/Makefile
index dc914946ff41..c14933eebda4 100644
--- a/sys/modules/Makefile
+++ b/sys/modules/Makefile
@@ -908,8 +908,7 @@ SUBDIR:= ${SUBDIR:N${reject}}
 .endif # MODULES_OVERRIDE -- Keep last
 
 # Calling kldxref(8) for each module is expensive.
-# XXX: kldxref lacks support for arm
-.if !defined(NO_XREF) && ${MACHINE_CPUARCH} != "arm"
+.if !defined(NO_XREF)
 .MAKEFLAGS+=	-DNO_XREF
 afterinstall: .PHONY
 	${KLDXREF_CMD} ${DESTDIR}${KMODDIR}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202312141831.3BEIVxUQ067256>