From owner-freebsd-hackers@FreeBSD.ORG Tue Oct 13 00:16:29 2009 Return-Path: Delivered-To: hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3C5A2106566B for ; Tue, 13 Oct 2009 00:16:29 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id DDE5E8FC14 for ; Tue, 13 Oct 2009 00:16:28 +0000 (UTC) Received: (qmail 20863 invoked by uid 399); 12 Oct 2009 23:49:48 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 12 Oct 2009 23:49:48 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4AD3C09B.70801@FreeBSD.org> Date: Mon, 12 Oct 2009 16:49:47 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: hackers@FreeBSD.org References: <20091011145021.GG36937@acme.spoerlein.net> In-Reply-To: <20091011145021.GG36937@acme.spoerlein.net> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: Re: RFC: Big Makefile patch for WARNS settings X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2009 00:16:29 -0000 Ulrich Spörlein wrote: > Dear -hackers, > > I would like you to give me your thoughts on the attached patch. There > are no functional changes, what I'm trying to do is introduce WARNS?=6 > for all top-level Makefiles and override that on a subdir basis. > > Why the churn? Because I think it sticks out more, if there's a WARNS=0 > in your Makefile rather than the default being WARNS=0. Perhaps this > gets more incentive going for fixing these WARNS. I don't see how this provides an incentive at all. I also object to this change on the grounds that down the road debugging is potentially going to be more difficult when someone forgets that there is a default WARNS level of 6. One of the strengths of the BSD-style make is the amount of routine stuff that goes on behind the scenes to make it easier to write good makefiles. However I don't think this should be one of those things. > There's also a lot of > work done by the DragonflyBSD folks which I intend to port peu a peu. Can you elaborate on this? What work are you planning to port over, and how does it depend on this default WARNS level issue? > Note: There are lots of style changes for games/ and sbin/, which I can > seperate out for easier review. But I'd like to make some sweeping > patches to bring them more inline with style.Makefile(5) Putting these two changes in the same patch is not a good thing. It makes it harder to read diffs, and commits that address separate issues should be done separately anyway. That said, I think that the style-compliance issue is a valid one, and I personally would be in favor of that happening after the 8.0-release, FWIW. hth, Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/