From owner-svn-src-all@FreeBSD.ORG  Fri Dec  3 16:52:02 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 571731065670;
	Fri,  3 Dec 2010 16:52:02 +0000 (UTC) (envelope-from das@FreeBSD.ORG)
Received: from zim.MIT.EDU (ZIM.MIT.EDU [18.95.3.101])
	by mx1.freebsd.org (Postfix) with ESMTP id 13C888FC13;
	Fri,  3 Dec 2010 16:52:01 +0000 (UTC)
Received: from zim.MIT.EDU (localhost [127.0.0.1])
	by zim.MIT.EDU (8.14.4/8.14.2) with ESMTP id oB3Gq1bJ036434;
	Fri, 3 Dec 2010 11:52:01 -0500 (EST) (envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by zim.MIT.EDU (8.14.4/8.14.2/Submit) id oB3Gq1Pf036433;
	Fri, 3 Dec 2010 11:52:01 -0500 (EST) (envelope-from das@FreeBSD.ORG)
Date: Fri, 3 Dec 2010 11:52:01 -0500
From: David Schultz <das@FreeBSD.ORG>
To: Kostik Belousov <kostikbel@gmail.com>
Message-ID: <20101203165201.GA36319@zim.MIT.EDU>
Mail-Followup-To: Kostik Belousov <kostikbel@gmail.com>,
	src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
References: <201006121732.o5CHW5Cs065722@svn.freebsd.org>
	<20100615084939.GL13238@deviant.kiev.zoral.com.ua>
	<20100615131443.GA93094@zim.MIT.EDU>
	<20101202045728.GA19295@zim.MIT.EDU>
	<20101202095652.GQ2392@deviant.kiev.zoral.com.ua>
	<20101202190010.GB28587@zim.MIT.EDU>
	<20101203005417.GZ2392@deviant.kiev.zoral.com.ua>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101203005417.GZ2392@deviant.kiev.zoral.com.ua>
Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG,
	src-committers@FreeBSD.ORG
Subject: Re: svn commit: r209110 - in head/lib/msun: . src
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Dec 2010 16:52:02 -0000

On Fri, Dec 03, 2010, Kostik Belousov wrote:
> On Thu, Dec 02, 2010 at 02:00:10PM -0500, David Schultz wrote:
> > On Thu, Dec 02, 2010, Kostik Belousov wrote:
> > > For __isnanf, libc exports __isnanf@FBSD_1.0, and libm exports
> > > __isnanf@FBSD_1.2. I suspect that we could export both
> > > __isnanf@FBSD_1.0 and __isnanf@FBSD_1.2 from libc.
> > 
> > I like the idea of adding an __isnanf@FBSD_1.2 alias to libc for
> > the benefit of people running -CURRENT.
> 
> Ok, draft of the change is below, I am not sure is it worth the churn.
> 
> I was unable to make the ld support two versions of the same symbol.
> lib/msun would benefit from elimination of isnan sources if this is
> committed.
[...]
> --- /dev/null
> +++ b/lib/libc/gen/isnan_compat.c
> @@ -0,0 +1,17 @@
> +/*
> + * The file is in public domain.
> + * Written by Konstantin Belousov <kib@FreeBSD.org>
> + *
> + * $FreeBSD$
> + */
> +
> +#include <math.h>
> +
> +__sym_compat(__isnanf, __isnanf_compat, FBSD_1.0);
> +
> +int
> +__isnanf_compat(float f)
> +{
> +
> +	return (__isnanf(f));
> +}

Thanks.  Hmm... if it ultimately entails replacing a small amount
of cruft in libm with a small amount of cruft in libc, it's
probably not worth the churn.