From owner-svn-src-head@freebsd.org  Mon Mar 30 01:29:57 2020
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id A300C26AEE3;
 Mon, 30 Mar 2020 01:29:57 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 48rFJ36RJ6z4TBP;
 Mon, 30 Mar 2020 01:29:55 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1])
 by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 02U1TewR053707;
 Sun, 29 Mar 2020 18:29:40 -0700 (PDT)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: (from freebsd@localhost)
 by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 02U1TeCE053706;
 Sun, 29 Mar 2020 18:29:40 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
Message-Id: <202003300129.02U1TeCE053706@gndrsh.dnsmgr.net>
Subject: Re: svn commit: r359419 - head/usr.bin/ncal
In-Reply-To: <20200329222800.GE87815@eureka.lemis.com>
To: "Greg 'groggy' Lehey" <grog@FreeBSD.org>
Date: Sun, 29 Mar 2020 18:29:40 -0700 (PDT)
CC: rgrimes@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, 
 svn-src-head@FreeBSD.org
Reply-To: rgrimes@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Rspamd-Queue-Id: 48rFJ36RJ6z4TBP
X-Spamd-Bar: -----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-5.99 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-0.995,0];
 NEURAL_HAM_LONG(-1.00)[-0.999,0]; REPLY(-4.00)[]
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Mar 2020 01:29:57 -0000

> On Sunday, 29 March 2020 at  4:03:09 -0700, Rodney W. Grimes wrote:
> >> Author: grog
> >> Date: Sun Mar 29 04:18:27 2020
> >> New Revision: 359419
> >> URL: https://svnweb.freebsd.org/changeset/base/359419
> >>
> >> Log:
> >>   Remove spurious transition from Julian to Gregorian for country
> >>   "Latin".
> >>
> >>   Arguably the entire -p option should be removed.  It shows only a few
> >>   countries, and it doesn't have any relationship with the rest of the
> >>   program.
> >
> > This commit message and the diff below do not seem to match very well.
> > Is this actually what you intended to commit?
> 
> The material difference, yes.  Do you have an issue with that?

No, just that it seemed that an error may of happened,
but having you confirm this infact was the inteded change
I am quiet fine with it.

> 
> It seems that some trailing blanks in unrelated text were removed as
> well.  diff doesn't show these by default, so they crept through.  I
> know it's bad style to mix style commits with functional commits, but
> ultimately they had to go too.

Diff by default does show white space change,
one has to invoke it with -b or -w or one of the --ignore space
change options to cause it to not show them.

> Greg
-- 
Rod Grimes                                                 rgrimes@freebsd.org