Date: Wed, 16 Jan 2002 11:07:41 -0800 From: Alfred Perlstein <bright@mu.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Ian Dowse <iedowse@maths.tcd.ie>, "Alan L. Cox" <alc@imimic.com>, FreeBSD-hackers@FreeBSD.ORG, re@FreeBSD.ORG Subject: Re: Need review of NFS patch set for server .. missing/wrong vput() issues Message-ID: <20020116110741.C26067@elvis.mu.org> In-Reply-To: <200201161850.g0GIowg68383@apollo.backplane.com>; from dillon@apollo.backplane.com on Wed, Jan 16, 2002 at 10:50:58AM -0800 References: <200201130239.aa98693@salmon.maths.tcd.ie> <200201161850.g0GIowg68383@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* Matthew Dillon <dillon@apollo.backplane.com> [020116 10:51] wrote: > > : > :In message <200201130201.g0D21Xh49451@apollo.backplane.com>, Matthew Dillon wri > :tes: > :> Ok, cool. I'll get the commit gears started for the > :> first part of the patch. > : > :FYI, I was able to reproduce this and confirm that the first part > :of your patch fixes it. All that it takes is for the mknod to fail > :because the name already exists, but normally this is masked by the > :client because it does an NFSPROC_ACCESS RPC first. > : > :Another nasty bug in nfsrv_mknod that I just spotted is that it > :doesn't override the S_IFMT bits of the file mode supplied by the > :client. It should be completely ignoring those bits, and using only > :the node-type it has in the `vtyp' variable. I just managed to > :create a node that makes ls say "Bad file descriptor" by passing > :in a type of NFFIFO and a mode of 0... > : > :Ian > > Alexey hasn't had any crashes since applying this part of the NFS mknod > patch. I assume it is a go, but the RE's have yet to respond to my MFC > request. > > Two real questions are whether the recent NFS fixes by Ian and the > recent softupdates fixes by Kirk should be MFC'd (in addition to my > NFS fix). I think Ian's mknod tests are a no-brainer. They should > just go in, as should my mknod fix. I agree, I'd really like to see this fixes in. -Alfred To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020116110741.C26067>