From owner-freebsd-arch@FreeBSD.ORG Tue Apr 1 00:22:34 2003 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 03E2637B407 for ; Tue, 1 Apr 2003 00:22:34 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2FF2243F3F for ; Tue, 1 Apr 2003 00:22:33 -0800 (PST) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.8/8.12.8) with ESMTP id h318MUSM031465 for ; Tue, 1 Apr 2003 10:22:31 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: arch@freebsd.org From: Poul-Henning Kamp Date: Tue, 01 Apr 2003 10:22:30 +0200 Message-ID: <31464.1049185350@critter.freebsd.dk> Subject: #include and X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Apr 2003 08:22:34 -0000 As we progress down the path of SMPng we will need to include and in more and more files. The current score, not counting nested include cases, they currently are included approx 16% and 19% of all .c files under /sys. My present predicament is that I will probably put a mutex in the bio queue which is defined in , and so far, I've found 20 .c files where I need to add and and I am not yet at a point where LINT compiles. Do we have a plan for these in the future ? I can see three obvious options: A) define them leaf #includes, and #include them from the majority of our .c files. B) Include them nested from other .h files which need them, in my case C) Include them nested from a central .h file like -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.