From owner-cvs-all@FreeBSD.ORG Thu Oct 27 07:40:54 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1305F16A41F; Thu, 27 Oct 2005 07:40:54 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id AFE6243D48; Thu, 27 Oct 2005 07:40:53 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9R7erMU024069; Thu, 27 Oct 2005 00:40:53 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9R7ermR024068; Thu, 27 Oct 2005 00:40:53 -0700 (PDT) (envelope-from obrien) Date: Thu, 27 Oct 2005 00:40:53 -0700 From: "David O'Brien" To: Roman Kurakin Message-ID: <20051027074053.GA24024@dragon.NUXI.org> References: <200509271657.j8RGvj2n015326@repoman.freebsd.org> <20051024072423.GA34909@dragon.NUXI.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051024072423.GA34909@dragon.NUXI.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/cp if_cp.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2005 07:40:54 -0000 On Mon, Oct 24, 2005 at 12:24:23AM -0700, David O'Brien wrote: > On Tue, Sep 27, 2005 at 04:57:45PM +0000, Roman Kurakin wrote: > > rik 2005-09-27 16:57:45 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/cp if_cp.c > > Log: > > Restore if_cp.c 1.27 > > ---------------------------- > > revision 1.27 > > date: 2005/09/19 03:10:16; author: imp; state: Exp; lines: +3 -2 > > Make sure that we call if_free(ifp) after bus_teardown_intr. Since we > > could get an interrupt after we free the ifp, and the interrupt > > handler depended on the ifp being still alive, this could, in theory, > > cause a crash. Eliminate this possibility by moving the if_free to > > after the bus_teardown_intr() call. > > > > In fact, this change do nothing for this driver. It is protected from > > this by cp_destroy variable. This variable also protects driver from > > initiation of any activity from network stack with disabled intr > > handler with this change applied. > > You should not have backed out my commit without discussing it with me > and understanding the reason for the change. > Do it again and I *will* be taking it Core. rik, I'm sorry this reads as such an aggressive email. I thought we were in a discussion about the reason of my commit and was surprised to see your commit happened in the middle of what I thought was an on-going thread.