From owner-freebsd-usb@FreeBSD.ORG  Sat Dec 20 09:30:09 2014
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D70399EE
 for <freebsd-usb@freebsd.org>; Sat, 20 Dec 2014 09:30:09 +0000 (UTC)
Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 949781770
 for <freebsd-usb@freebsd.org>; Sat, 20 Dec 2014 09:30:09 +0000 (UTC)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id C1B961FE022;
 Sat, 20 Dec 2014 10:30:00 +0100 (CET)
Message-ID: <549541BC.6070505@selasky.org>
Date: Sat, 20 Dec 2014 10:30:36 +0100
From: Hans Petter Selasky <hps@selasky.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Nidal Khalil <nedmath@gmail.com>, 
 Kohji Okuno <okuno.kohji@jp.panasonic.com>
Subject: Re: About XHCI_TD_PAGE_SIZE.
References: <20141217.110334.1811096089058017495.okuno.kohji@jp.panasonic.com>
 <CADoY-6gXxYvw-Raq-LW6q_QmiG8F=W6msZs2Q3vcx3s1LnksLw@mail.gmail.com>
In-Reply-To: <CADoY-6gXxYvw-Raq-LW6q_QmiG8F=W6msZs2Q3vcx3s1LnksLw@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-usb@freebsd.org
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb/>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Dec 2014 09:30:09 -0000

On 12/17/14 05:42, Nidal Khalil wrote:
> I agree. Thanks
>
> Nidal
> On Dec 16, 2014 6:25 PM, "Kohji Okuno" <okuno.kohji@jp.panasonic.com> wrote:
>
>> Hi Hans,
>>
>> If we use PAGE_SIZE as USB_PAGE_SIZE, we should use PAGE_SIZE as
>> XHCI_TD_PAGE_SIZE, too. I think.
>>
>> As you know, one TRB can use 1~64kB for the transfer length.
>>

Hi,

We currently only check if 4K pages are supported by the hardware. If 
you change the value of XHCI_TD_PAGE_SIZE, you will also need to change 
the checks other places. You know that PAGE_SIZE is not a constant?

Do you have a complete patch?

--HPS