From owner-svn-ports-all@freebsd.org Mon Nov 5 10:28:03 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89F9B10FF0DF; Mon, 5 Nov 2018 10:28:03 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1B4BE795C4; Mon, 5 Nov 2018 10:28:03 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 0D7461C28D; Mon, 5 Nov 2018 10:28:03 +0000 (UTC) Date: Mon, 5 Nov 2018 10:28:03 +0000 From: Alexey Dokuchaev To: Mathieu Arnold Cc: Mark Linimon , Rene Ladan , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r484041 - head/devel/heimdall Message-ID: <20181105102802.GA34032@FreeBSD.org> References: <201811041345.wA4DjCGN025777@repo.freebsd.org> <20181104151315.GA61162@FreeBSD.org> <20181104172918.GA21261@lonesome.com> <20181105060132.GA4050@FreeBSD.org> <20181105101623.hb2q56kavr4hbp4h@atuin.in.mat.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181105101623.hb2q56kavr4hbp4h@atuin.in.mat.cc> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 1B4BE795C4 X-Spamd-Result: default: False [-0.54 / 200.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[6]; NEURAL_SPAM_MEDIUM(0.22)[0.221,0]; MX_GOOD(-0.01)[cached: mx66.freebsd.org]; NEURAL_HAM_SHORT(-0.66)[-0.655,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2018 10:28:03 -0000 On Mon, Nov 05, 2018 at 11:16:23AM +0100, Mathieu Arnold wrote: > On Mon, Nov 05, 2018 at 06:01:32AM +0000, Alexey Dokuchaev wrote: > > On Sun, Nov 04, 2018 at 05:29:18PM +0000, Mark Linimon wrote: > > > On Sun, Nov 04, 2018 at 03:13:15PM +0000, Alexey Dokuchaev wrote: > > > > I don't understand, why not just fix the code by removing offending > > > > part: > > > > > > portsjail% grep -v "#" ../analysis/clang6_regressions.work | wc -l > > > 261 > > > > > > Fixing 261 ports is more than one person can do IMVVHO. > > > > Okay, but I'm talking about one particular port (which is maintained, > > so one might expect that maintainer has some knowledge of the code) > > and I've attached a patch. I believe it is quite doable by one person > > in this very case. :-) > > Once again, you fail to understand that it is not the job of portmgr to > fix all the broken things, it is to curate the ports tree. I understand that Mathieu. > If we find a simple fix, like here, we do that My point exactly; I didn't imply that someone(tm) should go down the entire logstash and relentlessly try to fix the code no matter what. Good that we agree. This, like you've correctly put, was a simple, easy to find fix (committed in r484179 FWIW). ./danfe