From owner-cvs-all@FreeBSD.ORG Thu Nov 1 13:07:28 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9EAEB16A417; Thu, 1 Nov 2007 13:07:28 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9264F13C4A6; Thu, 1 Nov 2007 13:07:28 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lA1D7Snf054475; Thu, 1 Nov 2007 13:07:28 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lA1D7SNF054474; Thu, 1 Nov 2007 13:07:28 GMT (envelope-from kensmith) Message-Id: <200711011307.lA1D7SNF054474@repoman.freebsd.org> From: Ken Smith Date: Thu, 1 Nov 2007 13:07:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/usr.sbin/sysinstall config.c dmenu.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2007 13:07:28 -0000 kensmith 2007-11-01 13:07:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.sbin/sysinstall config.c dmenu.c Log: MFC v1.243 of config.c and v1.48 of dmenu.c - fixes needed because sysinstall had made bad assumptions about the behavior of getenv(3) and the new getenv(3) doesn't behave the same as the old one did if you call it with getenv("amd_enable=YES"). It was noted during review that the use of strdup(3) here is wrong and should be checked for NULL. It's worth noting that's what I meant when I said I conformed to sysinstall's style despite urges to do otherwise in the original commit. sysinstall is in desperate need of some major rototilling (or being thrown out...). Approved by: re (rwatson) Revision Changes Path 1.242.2.1 +6 -1 src/usr.sbin/sysinstall/config.c 1.47.2.1 +8 -4 src/usr.sbin/sysinstall/dmenu.c