From owner-svn-src-all@FreeBSD.ORG Sun Feb 8 20:20:58 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A729106566C for ; Sun, 8 Feb 2009 20:20:58 +0000 (UTC) (envelope-from christoph.mallon@gmx.de) Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by mx1.freebsd.org (Postfix) with SMTP id BCB808FC1B for ; Sun, 8 Feb 2009 20:20:57 +0000 (UTC) (envelope-from christoph.mallon@gmx.de) Received: (qmail invoked by alias); 08 Feb 2009 20:20:56 -0000 Received: from p54A3DED5.dip.t-dialin.net (EHLO tron.homeunix.org) [84.163.222.213] by mail.gmx.net (mp016) with SMTP; 08 Feb 2009 21:20:56 +0100 X-Authenticated: #1673122 X-Provags-ID: V01U2FsdGVkX19Wd1ZQp9RWc/blR14k12S7ktJkmwyKMfXPELZkf1 CrUtxFzT67hlon Message-ID: <498F3EA7.4050900@gmx.de> Date: Sun, 08 Feb 2009 21:20:55 +0100 From: Christoph Mallon User-Agent: Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: Rui Paulo References: <200902082000.n18K0aBr032797@svn.freebsd.org> In-Reply-To: <200902082000.n18K0aBr032797@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.53 Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org Subject: Re: svn commit: r188326 - in stable/7/sys: . contrib/pf dev/acpi_support dev/cxgb X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Feb 2009 20:20:58 -0000 Rui Paulo schrieb: > Author: rpaulo > Date: Sun Feb 8 20:00:36 2009 > New Revision: 188326 > URL: http://svn.freebsd.org/changeset/base/188326 > > Log: > MFC r186529 (stas): > - Fix incorrect array declaration that was causing the stack overflow > on some (most?) Asus laptops. > > Modified: > stable/7/sys/ (props changed) > stable/7/sys/contrib/pf/ (props changed) > stable/7/sys/dev/acpi_support/acpi_asus.c > stable/7/sys/dev/cxgb/ (props changed) > > Modified: stable/7/sys/dev/acpi_support/acpi_asus.c > ============================================================================== > --- stable/7/sys/dev/acpi_support/acpi_asus.c Sun Feb 8 20:00:33 2009 (r188325) > +++ stable/7/sys/dev/acpi_support/acpi_asus.c Sun Feb 8 20:00:36 2009 (r188326) > @@ -958,7 +958,9 @@ acpi_asus_sysctl_get(struct acpi_asus_so > static int > acpi_asus_sysctl_set(struct acpi_asus_softc *sc, int method, int arg) > { > - ACPI_STATUS status = AE_OK; > + ACPI_STATUS status = AE_OK; > + ACPI_OBJECT_LIST acpiargs; > + ACPI_OBJECT acpiarg[1]; > > ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__); > ACPI_SERIAL_ASSERT(asus); r186529 does not seem to apply to 7.x, because you just added two unused variables. Maybe you forgot to MFC something else (r180268?) first.