Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Apr 2018 19:23:19 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r333034 - head/sys/x86/x86
Message-ID:  <201804261923.w3QJNJ6M057474@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Thu Apr 26 19:23:19 2018
New Revision: 333034
URL: https://svnweb.freebsd.org/changeset/base/333034

Log:
  Fix spelling: Appolo -> Apollo [1].
  The APL31 NDA errata is APL30 public errata.  Add the reference and
  provide the description [2].
  
  Noted by:	emaste [2], rpokala [1]
  Sponsored by:	The FreeBSD Foundation
  MFC after:	1 week

Modified:
  head/sys/x86/x86/cpu_machdep.c

Modified: head/sys/x86/x86/cpu_machdep.c
==============================================================================
--- head/sys/x86/x86/cpu_machdep.c	Thu Apr 26 19:15:39 2018	(r333033)
+++ head/sys/x86/x86/cpu_machdep.c	Thu Apr 26 19:23:19 2018	(r333034)
@@ -578,7 +578,7 @@ out:
 static int cpu_idle_apl31_workaround;
 SYSCTL_INT(_machdep, OID_AUTO, idle_apl31, CTLFLAG_RW,
     &cpu_idle_apl31_workaround, 0,
-    "Appolo Lake APL31 MWAIT bug workaround");
+    "Apollo Lake APL31 MWAIT bug workaround");
 
 int
 cpu_idle_wakeup(int cpu)
@@ -696,7 +696,11 @@ cpu_idle_tun(void *unused __unused)
 		cpu_idle_selector(tunvar);
 	if (cpu_vendor_id == CPU_VENDOR_INTEL && cpu_id == 0x506c9) {
 		/*
-		 * Appolo Lake errata APL31.
+		 * Apollo Lake errata APL31 (public errata APL30).
+		 * Stores to the armed address range may not trigger
+		 * MWAIT to resume execution.  OS needs to use
+		 * interrupts to wake processors from MWAIT-induced
+		 * sleep states.
 		 */
 		cpu_idle_apl31_workaround = 1;
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804261923.w3QJNJ6M057474>