From owner-svn-src-all@freebsd.org Thu Jan 23 18:23:00 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8AC701F9C2A for ; Thu, 23 Jan 2020 18:23:00 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 483Vxv5Hk4z3xdp for ; Thu, 23 Jan 2020 18:22:59 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: by mail-pg1-x530.google.com with SMTP id k3so1785356pgc.3 for ; Thu, 23 Jan 2020 10:22:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jroberson-net.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=My9XuQRnY7xN3vo+Fdj+y561ZEXgb73GZ+dVBJwg0yU=; b=E1+VuxF4dAqsMd5c6wci5JFhuBunhUFTf3uXxkSJqYk/HQXduOwBYcdv/Ay22qlDnM DCgq9QEXt5/AkKl9lRlnqFuyNdQXP0/M6avR8WKiZt/lvOHFYlu7eSfwJcL2Isz8oVH+ UrPxleMebWB66a0gwsuy49JyQsVOyvXeDDBbQX6GsueDHXloSVeQrfmL4RGojxkGoZUQ LNa9bVKgR76b2tzprG1ky+vqxznfCxJfUGnx4tFZHOcc+uCqDaPOmsAW1+VZLqns1Atm 5qSPGVY4YsAQFkakGO45biZ3RjXckjXPVQgiEaZVNhrtm3DuyFTaZRyrw21Ud5jxxD7m bcLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=My9XuQRnY7xN3vo+Fdj+y561ZEXgb73GZ+dVBJwg0yU=; b=hdrKMKlaftGkW2Uuq0qxNma2EYWJInJeNtXDbXNBw27IAi8Cf6H9qTpN7J26q5w5n8 T4XzoxgWcve4AVwlwoGKwDhTcns7VcWy6HedjDubEjQ+BEX8+hfbep7dISB4b+VTFaI5 NCDXmz5mfJuWNEwOP+5UQ8hJU4DLGWmiGmSoWfllYmeGbcNzEH4pq1bcoYVDveV9E+Kb Wx0H/3bgtYCni6nvLCN3xNnoBATPoTP4f/mM/IGGI0hw3jyk0iriJjPvjLIB971wOvob bkFrw5VIsDtdPSYrqvONifAGiwD7rfaTXrBoK69uj3kR/iHye8e8bLA1vIrA9ec0mTzZ qKUQ== X-Gm-Message-State: APjAAAV/yPuw/Qronalag203mQADQeILox0ThdK+m5kV9uoOpNuHtSYv RHwhOlKCBNUVVhKP+GoTyG8dyg== X-Google-Smtp-Source: APXvYqwP9IkBz41VgkkYqDXJr6P76K/Q1nmM1jwZYFQH9kfkS3F2WCzD8dzhBk3EtFfELN3R5z9URA== X-Received: by 2002:aa7:91c1:: with SMTP id z1mr8900260pfa.182.1579803777906; Thu, 23 Jan 2020 10:22:57 -0800 (PST) Received: from rrcs-76-81-105-82.west.biz.rr.com (rrcs-76-81-105-82.west.biz.rr.com. [76.81.105.82]) by smtp.gmail.com with ESMTPSA id c68sm3533321pfc.156.2020.01.23.10.22.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Jan 2020 10:22:57 -0800 (PST) Date: Thu, 23 Jan 2020 08:22:55 -1000 (HST) From: Jeff Roberson X-X-Sender: jroberson@desktop To: Mark Johnston cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r357055 - head/sys/sparc64/sparc64 In-Reply-To: <202001231718.00NHIwq7004333@repo.freebsd.org> Message-ID: References: <202001231718.00NHIwq7004333@repo.freebsd.org> User-Agent: Alpine 2.21.9999 (BSF 287 2018-06-16) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 483Vxv5Hk4z3xdp X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=jroberson-net.20150623.gappssmtp.com header.s=20150623 header.b=E1+VuxF4; dmarc=none; spf=none (mx1.freebsd.org: domain of jroberson@jroberson.net has no SPF policy when checking 2607:f8b0:4864:20::530) smtp.mailfrom=jroberson@jroberson.net X-Spamd-Result: default: False [-4.41 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[jroberson-net.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[jroberson.net]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[jroberson-net.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[0.3.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(-2.61)[ip: (-9.09), ipnet: 2607:f8b0::/32(-2.07), asn: 15169(-1.81), country: US(-0.05)] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2020 18:23:00 -0000 On Thu, 23 Jan 2020, Mark Johnston wrote: > Author: markj > Date: Thu Jan 23 17:18:58 2020 > New Revision: 357055 > URL: https://svnweb.freebsd.org/changeset/base/357055 > > Log: > sparc64: Busy the TSB page before freeing it in pmap_release(). > > This is now required by vm_page_free(). > > PR: 243534 > Reported and tested by: Michael Reim > > Modified: > head/sys/sparc64/sparc64/pmap.c > > Modified: head/sys/sparc64/sparc64/pmap.c > ============================================================================== > --- head/sys/sparc64/sparc64/pmap.c Thu Jan 23 17:08:33 2020 (r357054) > +++ head/sys/sparc64/sparc64/pmap.c Thu Jan 23 17:18:58 2020 (r357055) > @@ -1302,6 +1302,7 @@ pmap_release(pmap_t pm) > m = TAILQ_FIRST(&obj->memq); > m->md.pmap = NULL; > vm_page_unwire_noq(m); > + vm_page_xbusy(m); vm_page_xbusy() is unsafe long-term and I will be removing it as soon as I get patches into drm. It technically 'works' now but not for great reasons. Thanks, Jeff > vm_page_free_zero(m); > } > VM_OBJECT_WUNLOCK(obj); >