From owner-svn-src-all@FreeBSD.ORG Thu Jan 7 06:20:07 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DF64D1065672; Thu, 7 Jan 2010 06:20:07 +0000 (UTC) (envelope-from mckusick@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id CD63F8FC21; Thu, 7 Jan 2010 06:20:07 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o076K7Ba064980; Thu, 7 Jan 2010 06:20:07 GMT (envelope-from mckusick@svn.freebsd.org) Received: (from mckusick@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o076K7uA064978; Thu, 7 Jan 2010 06:20:07 GMT (envelope-from mckusick@svn.freebsd.org) Message-Id: <201001070620.o076K7uA064978@svn.freebsd.org> From: Kirk McKusick Date: Thu, 7 Jan 2010 06:20:07 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r201717 - head/sys/ufs/ufs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2010 06:20:08 -0000 Author: mckusick Date: Thu Jan 7 06:20:07 2010 New Revision: 201717 URL: http://svn.freebsd.org/changeset/base/201717 Log: KASSERT that condition raised by Coverity cannot happen. Found by: Coverity Prevent (tm) KASSERT by: sam Modified: head/sys/ufs/ufs/ufs_dirhash.c Modified: head/sys/ufs/ufs/ufs_dirhash.c ============================================================================== --- head/sys/ufs/ufs/ufs_dirhash.c Thu Jan 7 04:47:09 2010 (r201716) +++ head/sys/ufs/ufs/ufs_dirhash.c Thu Jan 7 06:20:07 2010 (r201717) @@ -632,6 +632,7 @@ restart: goto fail; } } + KASSERT(bp != NULL, ("no buffer allocated")); dp = (struct direct *)(bp->b_data + (offset & bmask)); if (dp->d_reclen == 0 || dp->d_reclen > DIRBLKSIZ - (offset & (DIRBLKSIZ - 1))) {