From owner-freebsd-ports-bugs@FreeBSD.ORG Wed May 30 19:30:11 2007 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 15AF816A41F for ; Wed, 30 May 2007 19:30:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id E15A513C455 for ; Wed, 30 May 2007 19:30:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l4UJUAJu020226 for ; Wed, 30 May 2007 19:30:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l4UJUAEP020224; Wed, 30 May 2007 19:30:10 GMT (envelope-from gnats) Date: Wed, 30 May 2007 19:30:10 GMT Message-Id: <200705301930.l4UJUAEP020224@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Rene Ladan Cc: Subject: Re: ports/113099: [PATCH] sysutils/libchk may skip $X11BASE now X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Rene Ladan List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2007 19:30:11 -0000 The following reply was made to PR ports/113099; it has been noted by GNATS. From: Rene Ladan To: knu@freebsd.org Cc: Dejan Lesjak , freebsd-x11@freebsd.org, bug-followup@freebsd.org Subject: Re: ports/113099: [PATCH] sysutils/libchk may skip $X11BASE now Date: Wed, 30 May 2007 21:26:58 +0200 This is a multi-part message in MIME format. --------------080601010909080703060101 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Dejan Lesjak wrote: > USE_NONDEFAULT_X11BASE is only relevant on FreeBSD before 6.2 (as we cant set > the default X11BASE in ports infrastructure there). On newer versions one can > define different X11BASE even without also setting USE_NONDEFAULT_X11BASE. > The ability to do that is left intentionally. > Anyhow, perhaps a more general solution for libchk might be to skip $X11BASE > if it is the same as $LOCALBASE? > This sounds reasonable. Akinori, what do you think of the attached patch? -- GPG fingerprint = E738 5471 D185 7013 0EE0 4FC8 3C1D 6F83 12E1 84F6 (subkeys.pgp.net) "It won't fit on the line." -- me, 2001 --------------080601010909080703060101 Content-Type: text/plain; name="libchk.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="libchk.diff" --- /usr/local/sbin/libchk Mon May 28 01:27:15 2007 +++ libchk2 Wed May 30 21:25:48 2007 @@ -27,6 +27,8 @@ # SUCH DAMAGE. # +# (rene) 20070530 : skip $X11BASE if $X11BASE == $LOCALBASE + RCS_ID = %q$Idaemons: /home/cvs/libchk/libchk.rb,v 1.9 2004/05/14 17:11:09 knu Exp $ RCS_REVISION = RCS_ID.split[2] MYNAME = File.basename($0) @@ -55,10 +57,15 @@ "#{$localbase}/bin", "#{$localbase}/libexec", "#{$localbase}/sbin", - "#{$x11base}/bin", - "#{$x11base}/libexec", - "#{$x11base}/sbin", ] + + if $x11base != $localbase + $bindirs += [ + "#{$x11base}/bin", + "#{$x11base}/libexec", + "#{$x11base}/sbin", + ] + end $exclude_dirs = [] end --------------080601010909080703060101--