From owner-p4-projects@FreeBSD.ORG Fri Jun 8 18:28:43 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 6DD3D16A46F; Fri, 8 Jun 2007 18:28:43 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4511516A41F; Fri, 8 Jun 2007 18:28:43 +0000 (UTC) (envelope-from arr@watson.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by mx1.freebsd.org (Postfix) with ESMTP id ED4BC13C483; Fri, 8 Jun 2007 18:28:42 +0000 (UTC) (envelope-from arr@watson.org) Received: from fledge.watson.org (localhost.watson.org [127.0.0.1]) by fledge.watson.org (8.13.8/8.13.8) with ESMTP id l58I4EM0016412; Fri, 8 Jun 2007 14:04:15 -0400 (EDT) (envelope-from arr@watson.org) Received: from localhost (arr@localhost) by fledge.watson.org (8.13.8/8.13.8/Submit) with ESMTP id l58I4E2m016409; Fri, 8 Jun 2007 14:04:14 -0400 (EDT) (envelope-from arr@watson.org) X-Authentication-Warning: fledge.watson.org: arr owned process doing -bs Date: Fri, 8 Jun 2007 14:04:14 -0400 (EDT) From: "Andrew R. Reiter" To: Attilio Rao In-Reply-To: <3bbf2fe10706081100k4f1457f2g6a714d8c897dc395@mail.gmail.com> Message-ID: <20070608140348.A14510@fledge.watson.org> References: <200706021756.l52Huq9A049371@repoman.freebsd.org> <86myzeq67f.wl%rpaulo@fnop.net> <4666B730.9080908@FreeBSD.org> <200706081351.54281.jhb@freebsd.org> <3bbf2fe10706081100k4f1457f2g6a714d8c897dc395@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (fledge.watson.org [127.0.0.1]); Fri, 08 Jun 2007 19:04:15 +0100 (BST) Cc: Rui Paulo , Perforce Change Reviews , Rui Paulo , John Baldwin Subject: Re: PERFORCE change 120788 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2007 18:28:43 -0000 On Fri, 8 Jun 2007, Attilio Rao wrote: > 2007/6/8, John Baldwin : >> On Wednesday 06 June 2007 09:31:28 am Attilio Rao wrote: >> > Rui Paulo wrote: >> > > >> > > If I'm not doing something wrong, I need to use spin locks on my >> > > interrupt handler, or else witness_checkorder will complain with >> > > "blockable sleep lock". >> > > >> > > Note that I'm using FILTERs. >> > >> > So you are doing this in the wrong way. >> > In order to use correctly filters, please note that the support for them >> > is compile time choosen, so you need to wrapper all filter specific >> > parts using INTR_FILTER compat macro. >> >> Actually, if you only use a filter and not an ithread handler, you can do >> that >> now w/o needing to have any #ifdef INTR_FILTER stuff. > > In the case your kernel doesn't use filters (!INTR_FILTER) and you > pass a filter, it is automatically mapped to work as a fast handler? > > Attilio > When this conversation is completed, can this be documented?