Date: Mon, 9 Jan 2012 12:34:25 -0800 (PST) From: Don Lewis <truckman@FreeBSD.org> To: des@des.no Cc: current@FreeBSD.org Subject: Re: couldn't log on to my -CURRENT machine after upgrade to latest PAM Message-ID: <201201092034.q09KYPhM031978@gw.catspoiler.org> In-Reply-To: <86pqesy66w.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9 Jan, Dag-Erling Smørgrav wrote: > Don Lewis <truckman@FreeBSD.org> writes: >> After staring at the code a lot more, I see your point about the loss of >> information. The problem is that openpam_parse_chain() returns >> PAM_SUCCESS whether or not if found anything, but we want the loop to >> terminate when either an error is detected or if openpam_parse_chain() >> actually found something. Maybe changing the loop exit to something >> like this would work: >> >> if (ret != PAM_SUCCESS || pamh->chains[facility] != NULL) >> return (ret); > > The simplest fix for now is probably to revert r487; it applies cleanly > except for the first hunk, which is easy to apply manually. openpam_configure() checks whether or not pamh->chains[] is NULL, so I figured that was a good test once I figured out how openpam_parse_chain() was returning its results. Once you decide on a fix, I can move my old /etc/pam.conf back to test it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201201092034.q09KYPhM031978>