From owner-cvs-all Wed Mar 20 13:13:39 2002 Delivered-To: cvs-all@freebsd.org Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by hub.freebsd.org (Postfix) with ESMTP id 35DEE37B417 for ; Wed, 20 Mar 2002 13:13:26 -0800 (PST) Received: (qmail 17962 invoked from network); 20 Mar 2002 21:13:23 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail6.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 20 Mar 2002 21:13:23 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g2KLDuv63593; Wed, 20 Mar 2002 16:13:56 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200203202109.g2KL9Am89620@freefall.freebsd.org> Date: Wed, 20 Mar 2002 16:13:26 -0500 (EST) From: John Baldwin To: John Baldwin Subject: RE: cvs commit: src/sys/alpha/alpha trap.c src/sys/i386/i386 tra Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 20-Mar-2002 John Baldwin wrote: > jhb 2002/03/20 13:09:09 PST > > Modified files: > sys/alpha/alpha trap.c > sys/i386/i386 trap.c > sys/ia64/ia64 trap.c > sys/powerpc/powerpc trap.c > sys/sparc64/sparc64 trap.c > sys/sys proc.h > Log: > Change the way we ensure td_ucred is NULL if DIAGNOSTIC is defined. > Instead of caching the ucred reference, just go ahead and eat the > decerement and increment of the refcount. Now that Giant is pushed down > into crfree(), we no longer have to get Giant in the common case. In the > case when we are actually free'ing the ucred, we would normally free it on > the next kernel entry, so the cost there is not new, just in a different > place. This also removse td_cache_ucred from struct thread. This is > still only done #ifdef DIAGNOSTIC. > > Tested on: i386, alpha Although this wasn't tested on ia64, sparc64, and powerpc, if you look at the diff's the change is identical to identical code on all 5 platforms. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message