From owner-cvs-all@FreeBSD.ORG Tue Feb 15 21:56:07 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3738216A4D0 for ; Tue, 15 Feb 2005 21:56:07 +0000 (GMT) Received: from mail26.sea5.speakeasy.net (mail26.sea5.speakeasy.net [69.17.117.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8940843D2F for ; Tue, 15 Feb 2005 21:56:06 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 18857 invoked from network); 15 Feb 2005 21:56:06 -0000 Received: from server.baldwin.cx ([216.27.160.63]) (envelope-sender )AES256-SHA encrypted SMTP for ; 15 Feb 2005 21:56:06 -0000 Received: from [10.50.40.202] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id j1FLtvfN054965; Tue, 15 Feb 2005 16:56:01 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Alan Cox Date: Tue, 15 Feb 2005 16:52:12 -0500 User-Agent: KMail/1.6.2 References: <200502082025.j18KP72E069507@repoman.freebsd.org> <200502141630.56868.jhb@FreeBSD.org> <20050215062127.GA27360@cs.rice.edu> In-Reply-To: <20050215062127.GA27360@cs.rice.edu> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200502151652.12231.jhb@FreeBSD.org> X-Spam-Status: No, score=-102.8 required=4.2 tests=ALL_TRUSTED, USER_IN_WHITELIST autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: obrien@FreeBSD.org cc: cokane@cokane.org Subject: Re: cvs commit: src/sys/i386/i386 apic_vector.s local_apic.c mp_machdep.c src/sys/i386/include apicvar.h smp.h src/sys/i386/isa clock.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Feb 2005 21:56:07 -0000 On Tuesday 15 February 2005 01:21 am, Alan Cox wrote: > On Mon, Feb 14, 2005 at 04:30:56PM -0500, John Baldwin wrote: > > On Monday 14 February 2005 01:42 pm, Coleman Kane wrote: > > > I've been testing these since they were posted. All is well thus far! > > > > I need perf numbers though. They should work fine, but I really don't > > know if they will help or hurt performance. Also, the perf > > characteristics are likely different on UP vs SMP. > > In regards to the changes to atomic.h, I'm curious why you didn't make > the output of lfence and sfence conditional on SMP, like the output of > the lock prefix is? I wasn't sure if it would matter. Probably amd64 first needs to merge over the changes from i386 to not use fences for atomic_store_rel() for UP kernels as well first, and then use the fence instructions for just SMP kernels for now. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org