From owner-freebsd-current Wed Sep 23 22:02:59 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA28429 for freebsd-current-outgoing; Wed, 23 Sep 1998 22:02:59 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from zibbi.mikom.csir.co.za (zibbi.mikom.csir.co.za [146.64.24.58]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA28409 for ; Wed, 23 Sep 1998 22:02:43 -0700 (PDT) (envelope-from jhay@zibbi.mikom.csir.co.za) Received: (from jhay@localhost) by zibbi.mikom.csir.co.za (8.9.1/8.9.1) id HAA21032; Thu, 24 Sep 1998 07:02:28 +0200 (SAT) From: John Hay Message-Id: <199809240502.HAA21032@zibbi.mikom.csir.co.za> Subject: Re: Official softupdates patch for testers In-Reply-To: <199809230515.BAA08476@lor.watermarkgroup.com> from Luoqi Chen at "Sep 23, 98 01:15:38 am" To: luoqi@watermarkgroup.com (Luoqi Chen) Date: Thu, 24 Sep 1998 07:02:27 +0200 (SAT) Cc: current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL32 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > The following is the official patch to fix the 'initiate_write_filepage' panic, > plus two changes requested by Bruce Evans, > 1. Do not test for vn_lock() failures if LK_RETRY flag bit is set, vn_lock > can't fail in this case. > 2. In fsync() syscall, always call VOP_FSYNC() with MNT_WAIT flag. This would > make it a little safer for async mount and keep us in sync with other BSDs. > Please send any feedback to me . Thanks. This seems to work for me. I have tried it on a SMP machine with various -j levels for make world and also make release and never got a panic. Good work! Thanks. I did notice some warnings when compileing the kernel, which I didn't notice before. Maybe I just wasn't looking... --------------------------------- cc -c -O -pipe -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wuninitialized -Wformat -fformat-extensions -ansi -nostdinc -I- -I. -I../.. -I../../../include -DKERNEL -include opt_global.h -aout ../../ufs/ffs/ffs_softdep.c ../../ufs/ffs/ffs_softdep.c: In function `allocdirect_merge': ../../ufs/ffs/ffs_softdep.c:1266: warning: int format, ufs_lbn_t arg (arg 4) ../../ufs/ffs/ffs_softdep.c: In function `initiate_write_inodeblock': ../../ufs/ffs/ffs_softdep.c:2823: warning: int format, ufs_lbn_t arg (arg 3) ../../ufs/ffs/ffs_softdep.c:2828: warning: int format, long int arg (arg 3) ../../ufs/ffs/ffs_softdep.c: In function `handle_written_inodeblock': ../../ufs/ffs/ffs_softdep.c:3172: warning: int format, ufs_lbn_t arg (arg 4) ../../ufs/ffs/ffs_softdep.c:3179: warning: int format, long int arg (arg 4) ---------------------------------- John -- John Hay -- John.Hay@mikom.csir.co.za To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message