Date: Mon, 26 Jul 2021 01:08:47 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 257421] [NEW PORT] textproc/py-charset-normalizer: Universal Charset Detector. Open, modern alternative to Chardet Message-ID: <bug-257421-7788-pEawgK5C67@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-257421-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-257421-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257421 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |feature, needs-patch, | |needs-qa Status|New |Open CC| |0xdutra@gmail.com, | |python@FreeBSD.org Flags| |maintainer-feedback?(0xdutr | |a@gmail.com) Summary|[New Port] |[NEW PORT] |textproc/py-charset-normali |textproc/py-charset-normali |zer: Package for encoding & |zer: Universal Charset |language detection |Detector. Open, modern | |alternative to Chardet --- Comment #1 from Kubilay Kocak <koobs@FreeBSD.org> --- Thank you for submitting a new port Gabriel. Some review review items: - Match upstream short name / summary / show description, modulo portlint requirements. Suggested COMMENT change is this issues current summary (upda= te if required). - Match USES=3Dpython version spec to upstream (setup.py:REQUIRES in this = case) - Upstream defines no RUN_DEPENDS (install_requires) (setup.py: REQUIRED = =3D []) Be careful just copying requirements.txt. Upstream should have this as a test_requirements.txt and/or (better): extras_require [ devreqs =3D { ... , ... } ] so people can just `pip install charset-normalizer[devreqs]` - Upstream defines an extras_require, add an OPTION for this, named appropriately (the feature it provides) - The package provides tests. Add TEST_DEPENDS and do-test target accordin= gly. Tip: For pytest based tests, use the following invocation, which overrides = any 'extra stuff' set in setup.cfg:[tool:pytest] and other places. This will re= move the need for pycov, in this case: do-test: @cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopts=3D Have a run through our Python Packaging guidelines, and confirm if the test suite and poudriere tests pass: * https://wiki.freebsd.org/Python/PortsPolicy https://docs.freebsd.org/en/books/porters-handbook/testing-poudriere.html --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-257421-7788-pEawgK5C67>