From owner-freebsd-bugs  Sat Mar  2 06:40:03 1996
Return-Path: owner-bugs
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id GAA16786
          for bugs-outgoing; Sat, 2 Mar 1996 06:40:03 -0800 (PST)
Received: (from gnats@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id GAA16755
          Sat, 2 Mar 1996 06:40:01 -0800 (PST)
Resent-Date: Sat, 2 Mar 1996 06:40:01 -0800 (PST)
Resent-Message-Id: <199603021440.GAA16755@freefall.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@freefall.FreeBSD.org, enami@ba2.so-net.or.jp
Received: from mail.ba2.so-net.or.jp (mail.ba2.so-net.or.jp [202.238.95.33])
          by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id GAA16226
          for <FreeBSD-gnats-submit@freebsd.org>; Sat, 2 Mar 1996 06:32:19 -0800 (PST)
Received: from euphoria.enami.ba2.so-net.or.jp (ppp580e.ykhm.ap.so-net.or.jp [202.238.88.14]) by mail.ba2.so-net.or.jp (8.7.3/3.4W396011914) with ESMTP id XAA15496 for <FreeBSD-gnats-submit@freebsd.org>; Sat, 2 Mar 1996 23:32:11 +0900
Received: (from enami@localhost) by euphoria.enami.ba2.so-net.or.jp (8.7.4/3.4W4-euphoria) id XAA00902; Sat, 2 Mar 1996 23:36:27 +0900 (JST)
Message-Id: <199603021436.XAA00902@euphoria.enami.ba2.so-net.or.jp>
Date: Sat, 2 Mar 1996 23:36:27 +0900 (JST)
From: enami@ba2.so-net.or.jp
Reply-To: enami@ba2.so-net.or.jp
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: bin/1056: pppd failes if -detach
Sender: owner-bugs@freebsd.org
Precedence: bulk


>Number:         1056
>Category:       bin
>Synopsis:       pppd fails if -detach
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar  2 06:40:01 PST 1996
>Last-Modified:
>Originator:     enami tsugutomo
>Organization:
a hacker in japan
>Release:        FreeBSD 2.2-CURRENT i386
>Environment:
	FreeBSD 2.2, 486DX2, 12M mem, ...

>Description:
	pppd failes to set control terminal if -detach option is given.

>How-To-Repeat:
	Run pppd with -detach option.

>Fix:
	I think there is no need to set control terminal if pppd doesn't
	detached.

*** main.c	1996/03/02 13:36:46	1.1
--- main.c	1996/03/02 13:37:20
***************
*** 329,335 ****
  	hungup = 0;
  	kill_link = 0;
  
! 	if (!default_device)
  	    setsid();
  
  	/* run connection script */
--- 329,335 ----
  	hungup = 0;
  	kill_link = 0;
  
! 	if (!default_device && !nodetach)
  	    setsid();
  
  	/* run connection script */
***************
*** 360,366 ****
  	set_up_tty(fd, 0);
  
  	/* attach to the controlling tty for signals */
! 	if (!default_device && ioctl(fd, TIOCSCTTY) < 0) {
  	    syslog(LOG_ERR, "ioctl(TIOCSCTTY) : %m");
  	    die(1);
  	}
--- 360,366 ----
  	set_up_tty(fd, 0);
  
  	/* attach to the controlling tty for signals */
! 	if (!default_device && !nodetach && ioctl(fd, TIOCSCTTY) < 0) {
  	    syslog(LOG_ERR, "ioctl(TIOCSCTTY) : %m");
  	    die(1);
  	}
>Audit-Trail:
>Unformatted: