From owner-svn-src-head@freebsd.org Wed Apr 20 14:41:44 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77DF5B16F09; Wed, 20 Apr 2016 14:41:44 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ob0-f193.google.com (mail-ob0-f193.google.com [209.85.214.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 45B6C1EE9; Wed, 20 Apr 2016 14:41:44 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ob0-f193.google.com with SMTP id js7so4164301obc.0; Wed, 20 Apr 2016 07:41:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=RP5t7Eoj6lhI8lGX7z+Rp9FCo8N+akCwGDAORRn5Oy0=; b=lnV+FMffuIgxwAaXw0ufZWlemlp5BeLY8G8Cb93jBEZE9zUPhrV2Vkti8J4KNrzLxV FCaCZclPCWyaN7eJs4Pi4e2eEoOoK9Te0vkrI3HcPeA/XmqF51F+h6lFv1suyLlv4jsy X8CBvIulokuarFiyJu3YTkrWvTClyFKCGXXXLhS8RdrRANVm6RCAJTcvbfqRIgp2ToZ2 q8H7ofvN27jtxfenkGTy+OkwA6wVUpIXDqNWhwApBArhOPM4El5yQPxnjJgOkVr3ZT4m 5D1EGqKPiBtNlPc6W/fIXVNwx0ASXcB872dXThd/BlHv26hXJEcAxF6CBqZHTopXWVob MbBg== X-Gm-Message-State: AOPr4FVyITMabX5mW+fS3R229mq1UAxYEeRgpEpwWRFRiBekpruQYY0X7B4o1mZG1o0zVg== X-Received: by 10.182.49.6 with SMTP id q6mr3900680obn.79.1461163302786; Wed, 20 Apr 2016 07:41:42 -0700 (PDT) Received: from mail-oi0-f51.google.com (mail-oi0-f51.google.com. [209.85.218.51]) by smtp.gmail.com with ESMTPSA id n6sm22712570obi.4.2016.04.20.07.41.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Apr 2016 07:41:42 -0700 (PDT) Received: by mail-oi0-f51.google.com with SMTP id r78so42387937oie.0; Wed, 20 Apr 2016 07:41:42 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.157.6.65 with SMTP id 59mr4312066otn.39.1461163301971; Wed, 20 Apr 2016 07:41:41 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.157.22.215 with HTTP; Wed, 20 Apr 2016 07:41:41 -0700 (PDT) In-Reply-To: References: <201604190446.u3J4kD9G050780@repo.freebsd.org> <4114217.PtcV9LDMal@ralph.baldwin.cx> <20160420115844.Y967@besplex.bde.org> Date: Wed, 20 Apr 2016 07:41:41 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r298247 - head/sbin/fdisk_pc98 From: Conrad Meyer To: Pedro Giffuni Cc: Bruce Evans , araujo@freebsd.org, John Baldwin , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2016 14:41:44 -0000 On Wed, Apr 20, 2016 at 7:33 AM, Pedro Giffuni wrote: > One of the things I dislike is that most of the macros are in > lowercase. Lowercase would make sense if these were inline functions > but inline functions have disadvantages for these use cases. > OTOH, if they were uppercase, they would not be very easy on the eyes, > which is the current advantage. You bring up a good point. Obviously nitems() can't be an inline function, but roundup2() and friends could. Is there any reason not to change them over to inline functions? Best, Conrad