From owner-p4-projects@FreeBSD.ORG  Fri Feb 15 19:52:03 2013
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
 id 1BF11945; Fri, 15 Feb 2013 19:52:03 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id D4381943
 for <perforce@freebsd.org>; Fri, 15 Feb 2013 19:52:02 +0000 (UTC)
 (envelope-from brooks@freebsd.org)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org
 [IPv6:2001:1900:2254:2068::682:0])
 by mx1.freebsd.org (Postfix) with ESMTP id ACB4313D
 for <perforce@freebsd.org>; Fri, 15 Feb 2013 19:52:02 +0000 (UTC)
Received: from skunkworks.freebsd.org ([127.0.1.74])
 by skunkworks.freebsd.org (8.14.6/8.14.6) with ESMTP id r1FJq2LZ062614
 for <perforce@freebsd.org>; Fri, 15 Feb 2013 19:52:02 GMT
 (envelope-from brooks@freebsd.org)
Received: (from perforce@localhost)
 by skunkworks.freebsd.org (8.14.6/8.14.6/Submit) id r1FJq2JO062611
 for perforce@freebsd.org; Fri, 15 Feb 2013 19:52:02 GMT
 (envelope-from brooks@freebsd.org)
Date: Fri, 15 Feb 2013 19:52:02 GMT
Message-Id: <201302151952.r1FJq2JO062611@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
 brooks@freebsd.org using -f
From: Brooks Davis <brooks@FreeBSD.org>
Subject: PERFORCE change 222074 for review
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.14
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/p4-projects>,
 <mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
 <mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Feb 2013 19:52:03 -0000

http://p4web.freebsd.org/@@222074?ac=10

Change 222074 by brooks@brooks_zenith on 2013/02/15 19:51:10

	Explicitly close the output file descriptor so that work
	performed when the descriptor is closed is included in the
	summary output.

Affected files ...

.. //depot/projects/ctsrd/beribsd/src/bin/dd/dd.c#4 edit

Differences ...

==== //depot/projects/ctsrd/beribsd/src/bin/dd/dd.c#4 (text+ko) ====

@@ -98,6 +98,13 @@
 		dd_in();
 
 	dd_close();
+	/*
+	 * Some devices such as cfi(4) may perform significant amounts
+	 * of work when a write descriptor is closed.  Close the out
+	 * descriptor explicitly so that the summary handler (called
+	 * from an atexit() hook) includes this work.
+	 */
+	close(out.fd);
 	exit(0);
 }