From owner-cvs-all  Thu May 23  0:19:19 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1DFA837B40D; Thu, 23 May 2002 00:19:02 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id RAA25539;
	Thu, 23 May 2002 17:18:58 +1000
Date: Thu, 23 May 2002 17:21:49 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: John Baldwin <jhb@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/i386/include cpufunc.h src/sys/kern       
  kern_mutex.c
In-Reply-To: <200205222032.g4MKWdl17723@freefall.freebsd.org>
Message-ID: <20020523171421.L12695-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Wed, 22 May 2002, John Baldwin wrote:

> jhb         2002/05/22 13:32:39 PDT
>
>   Modified files:
>     sys/i386/include     cpufunc.h
>     sys/kern             kern_mutex.c
>   Log:
>   Rename pause() to ia32_pause() so it doesn't conflict with the pause()
>   function defined in <unistd.h>.  I didn't #ifdef _KERNEL it because the
>   mutex implementation in libpthread will probably need this.

This shoots the messenger.  The main bug is gross namespace pollution in
<vgl.h>:

%%%
#ifndef _VGL_H_
#define _VGL_H_

#include <stdlib.h>
#include <unistd.h>
#include <string.h>
#include <machine/cpufunc.h>
%%%

<machine/cpufunc.h> is really a kernel-only header, but it sometimes gets
abused in userland.  I think this shouldn't be supported.  It contains
mostly very machine-dependent interfaces, so it should be used in at most
the implementation of libvgl.  libvgl uses i386 interfaces unconditionally,
so it only works on i386's, but this limitation is not documented.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message