From owner-freebsd-bugs@FreeBSD.ORG Mon Apr 22 04:50:01 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id E5399A02 for ; Mon, 22 Apr 2013 04:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id C91911FE0 for ; Mon, 22 Apr 2013 04:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3M4o0Hq013925 for ; Mon, 22 Apr 2013 04:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3M4o0mu013924; Mon, 22 Apr 2013 04:50:00 GMT (envelope-from gnats) Resent-Date: Mon, 22 Apr 2013 04:50:00 GMT Resent-Message-Id: <201304220450.r3M4o0mu013924@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jeremy Chadwick Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id AA20F9C0 for ; Mon, 22 Apr 2013 04:44:43 +0000 (UTC) (envelope-from jdc@koitsu.org) Received: from qmta05.emeryville.ca.mail.comcast.net (qmta05.emeryville.ca.mail.comcast.net [IPv6:2001:558:fe2d:43:76:96:30:48]) by mx1.freebsd.org (Postfix) with ESMTP id 9182A1FC3 for ; Mon, 22 Apr 2013 04:44:43 +0000 (UTC) Received: from omta06.emeryville.ca.mail.comcast.net ([76.96.30.51]) by qmta05.emeryville.ca.mail.comcast.net with comcast id Ssho1l00316AWCUA5skiXy; Mon, 22 Apr 2013 04:44:42 +0000 Received: from koitsu.strangled.net ([67.180.84.87]) by omta06.emeryville.ca.mail.comcast.net with comcast id Sskh1l00W1t3BNj8Sskizh; Mon, 22 Apr 2013 04:44:42 +0000 Received: by icarus.home.lan (Postfix, from userid 1000) id B527073A33; Sun, 21 Apr 2013 21:44:41 -0700 (PDT) Message-Id: <20130422044441.B527073A33@icarus.home.lan> Date: Sun, 21 Apr 2013 21:44:41 -0700 (PDT) From: Jeremy Chadwick To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.114 Subject: kern/178040: [cam] [patch] Add 4K quirks for Intel 320 and 510-series SSDs Cc: Steven Hartland X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Jeremy Chadwick List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2013 04:50:02 -0000 >Number: 178040 >Category: kern >Synopsis: [cam] [patch] Add 4K quirks for Intel 320 and 510-series SSDs >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Mon Apr 22 04:50:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Jeremy Chadwick >Release: FreeBSD 9.1-STABLE amd64 >Organization: >Environment: System: FreeBSD icarus.home.lan 9.1-STABLE FreeBSD 9.1-STABLE #1 r249715M: Sun Apr 21 21:07:17 PDT 2013 root@icarus.home.lan:/usr/obj/usr/src/sys/X7SBA_RELENG_9_amd64 amd64 >Description: Intel's 320-series and 510-series SSDs advertise 512-byte sectors sizes for both logical and physical. This adds ADA_Q_4K quirks for both. (Intel, for whatever reason, didn't add physical sector advertisement in ATA IDENTIFY; maybe they're strictly adhering to non-draft specs, I don't know...) Validation of my claims: root@icarus:~ # smartctl -a /dev/ada0 ... Model Family: Intel 320 Series SSDs Device Model: INTEL SSDSA2CW080G3 ... Firmware Version: 4PC10302 User Capacity: 80,026,361,856 bytes [80.0 GB] Sector Size: 512 bytes logical/physical ... root@icarus:~ # smartctl -a /dev/ada5 ... Model Family: Intel 510 Series SSDs Device Model: INTEL SSDSC2MH120A2 ... Firmware Version: PPG4 User Capacity: 120,034,123,776 bytes [120 GB] Sector Size: 512 bytes logical/physical ... >How-To-Repeat: n/a >Fix: Apply below patch. Patch will also be available at the following URL once I get a GNATS PR: http://jdc.koitsu.org/freebsd/{prnum}/ Index: sys/cam/ata/ata_da.c =================================================================== --- sys/cam/ata/ata_da.c (revision 249745) +++ sys/cam/ata/ata_da.c (working copy) @@ -350,6 +350,14 @@ static struct ada_quirk_entry ada_quirk_table[] = }, { /* + * Intel 320 Series SSDs + * 4k optimised & trim only works in 4k requests + 4k aligned + */ + { T_DIRECT, SIP_MEDIA_FIXED, "*", "INTEL SSDSA2CW*", "*" }, + /*quirks*/ADA_Q_4K + }, + { + /* * Intel 330 Series SSDs * 4k optimised & trim only works in 4k requests + 4k aligned * Submitted by: Steven Hartland @@ -360,6 +368,14 @@ static struct ada_quirk_entry ada_quirk_table[] = }, { /* + * Intel 510 Series SSDs + * 4k optimised & trim only works in 4k requests + 4k aligned + */ + { T_DIRECT, SIP_MEDIA_FIXED, "*", "INTEL SSDSC2MH*", "*" }, + /*quirks*/ADA_Q_4K + }, + { + /* * OCZ Deneva R Series SSDs * 4k optimised & trim only works in 4k requests + 4k aligned * Submitted by: Steven Hartland >Release-Note: >Audit-Trail: >Unformatted: