From owner-cvs-ports@FreeBSD.ORG Sun Sep 25 20:36:07 2011 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EFFF7106566B; Sun, 25 Sep 2011 20:36:07 +0000 (UTC) (envelope-from zi@FreeBSD.org) Received: from fast.rit.edu (fast.rit.edu [129.21.182.30]) by mx1.freebsd.org (Postfix) with ESMTP id B88188FC0A; Sun, 25 Sep 2011 20:36:07 +0000 (UTC) Received: from fast.rit.edu (localhost.rit.edu [127.0.0.1]) by fast.rit.edu (Postfix) with ESMTP id DFFAC1D141; Sun, 25 Sep 2011 16:36:06 -0400 (EDT) X-Virus-Scanned: by amavisd-new at fast.rit.edu Received: from fast.rit.edu ([127.0.0.1]) by fast.rit.edu (fast.rit.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qkoazMhy49mm; Sun, 25 Sep 2011 16:36:06 -0400 (EDT) Received: from syn.rit.edu (syn.rit.edu [129.21.182.15]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by fast.rit.edu (Postfix) with ESMTPS id 0EF301D163; Sun, 25 Sep 2011 16:36:06 -0400 (EDT) Received: from syn.rit.edu (localhost.rit.edu [127.0.0.1]) by syn.rit.edu (8.14.4/8.14.3) with ESMTP id p8PKa5Hw026421; Sun, 25 Sep 2011 16:36:05 -0400 (EDT) (envelope-from zi@FreeBSD.org) Received: (from zi@localhost) by syn.rit.edu (8.14.4/8.14.3/Submit) id p8PKa4WN009563; Sun, 25 Sep 2011 16:36:04 -0400 (EDT) (envelope-from zi@FreeBSD.org) Date: Sun, 25 Sep 2011 16:36:04 -0400 From: Ryan Steinmetz To: Doug Barton Message-ID: <20110925203510.GA928@fast.rit.edu> References: <201109251647.p8PGl3Xm096164@repoman.freebsd.org> <4E7F84A3.8000702@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E7F84A3.8000702@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: cvs-ports@FreeBSD.org, Janos Mohacsi , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/ndpmon Makefile ports/net-mgmt/ndpmon/files ndpmonitor.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Sep 2011 20:36:08 -0000 On (09/25/11 12:44), Doug Barton wrote: > Overall the rc.d script looks good, just 2 questions. > > 1. Is there a reason that it's got REQUIRE: DAEMON NETWORKING instead of > the preferred REQUIRE: LOGIN? > 2. Is there a reason that it does not have KEYWORD: shutdown? Since it > seems to start a persistent daemon this is desirable. > > > Doug > > > On 09/25/2011 09:47, Ryan Steinmetz wrote: > > zi 2011-09-25 16:47:03 UTC > > > > FreeBSD ports repository > > > > Modified files: > > net-mgmt/ndpmon Makefile > > net-mgmt/ndpmon/files ndpmonitor.in > > Log: > > - Silence startup noise [1] > > - Fix build with custom PREFIX/LOCALBASE > > - Fix build when using CLANG > > - Add OPTIONS for MAC resolution > > - Add LICENSE > > > > PR: ports/159915 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=159915 > > Submitted by: Janos Mohacsi (maintainer) [1] > > > > Revision Changes Path > > 1.10 +12 -2 ports/net-mgmt/ndpmon/Makefile > > 1.5 +2 -2 ports/net-mgmt/ndpmon/files/ndpmonitor.in > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/ndpmon/Makefile.diff?&r1=1.9&r2=1.10&f=h > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/ndpmon/files/ndpmonitor.in.diff?&r1=1.4&r2=1.5&f=h > > > > > > -- > > Nothin' ever doesn't change, but nothin' changes much. > -- OK Go > > Breadth of IT experience, and depth of knowledge in the DNS. > Yours for the right price. :) http://SupersetSolutions.com/ > Doug, 1. No. I believe the original author simply copied what was in net-mgmt/arpwatch's rc script 2. No. I believe this is the same case as #1. An updated script will be committed shortly. Thanks! -r -- Ryan Steinmetz PGP: EF36 D45A 5CA9 28B1 A550 18CD A43C D111 7AD7 FAF2