From owner-svn-src-head@freebsd.org Fri Sep 25 23:13:01 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D1E8FA0859B; Fri, 25 Sep 2015 23:13:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id B8D5E127B; Fri, 25 Sep 2015 23:13:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id B2CF71DCF; Fri, 25 Sep 2015 23:13:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 6CB111393C; Fri, 25 Sep 2015 23:13:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id LD5vNfYCrn2J; Fri, 25 Sep 2015 23:12:59 +0000 (UTC) Subject: Re: svn commit: r288241 - head/share/mk DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com EB71713936 To: NGie Cooper References: <201509252303.t8PN3Wx0098623@repo.freebsd.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <5605D4FC.4040205@FreeBSD.org> Date: Fri, 25 Sep 2015 16:13:00 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2JAi8p1hwRXDg2XrCt9FIxHCetuBvdTAN" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2015 23:13:01 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2JAi8p1hwRXDg2XrCt9FIxHCetuBvdTAN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 9/25/2015 4:12 PM, NGie Cooper wrote: > On Fri, Sep 25, 2015 at 4:03 PM, Bryan Drewery w= rote: >> Author: bdrewery >> Date: Fri Sep 25 23:03:32 2015 >> New Revision: 288241 >> URL: https://svnweb.freebsd.org/changeset/base/288241 >> >> Log: >> Remove 'set -e' that are no longer needed as it is already default. >> >> When bmake was initially imported at r241298 shell commands were no = longer >> ran with 'set -e' as they were before. This was fixed in r254980 so= they >> again always use 'set -e'. >=20 > The bsd.subdir.mk portion of the change looks like it would cause > issues depending on what's being called (fmake or an earlier version > of sys.mk might be used at install time). >=20 We only support bmake in head. And the 'set -e' were only added for bmake compatibility before it was fixed to work like fmake did. --=20 Regards, Bryan Drewery --2JAi8p1hwRXDg2XrCt9FIxHCetuBvdTAN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWBdT8AAoJEDXXcbtuRpfPZDYIAKAuyVlQRu29FXResIK3In9U obAjNMswsfgwpan47JINR73sc4jo/qO1Myl/jq0jkJbgp4mlyk9qFFZj/CRlNvCi 7OAQ+LUp+H4EGKpeE7r+wpwhUGiWZFNul4QOtd1JriYHc0IGZnB8NiCkn7HdAo8d +IlBMG/DVzvP6/EDt75VPmkiKFSNb0om2Wo8Ei0BNPygUBfYem7bxc8Uew1S0QPi 2+7NM18Ylldr1/xGtHZ9mxsAyTK+TxkOI06wQIXoL1Pphk3nEtbyerOpxA4Gefq4 QmwsqW2JE/Xu/qulVUREaLOZye7C+Wk4QZiCnTZLtoLOf0bDAdekRJg1p8PhcUo= =4xHC -----END PGP SIGNATURE----- --2JAi8p1hwRXDg2XrCt9FIxHCetuBvdTAN--