From owner-cvs-all  Thu Dec 20 13: 5:58 2001
Delivered-To: cvs-all@freebsd.org
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by hub.freebsd.org (Postfix) with ESMTP
	id C8D2437B405; Thu, 20 Dec 2001 13:05:50 -0800 (PST)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.11.6/8.11.6) with ESMTP id fBKJTWt00669;
	Thu, 20 Dec 2001 20:29:32 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Bruce Evans <bde@zeta.org.au>
Cc: Peter Wemm <peter@freebsd.org>, cvs-committers@freebsd.org,
	cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/alpha/alpha pmap.c src/sys/i386/i386 pmap.c src/sys/ia64/ia64 pmap.c 
In-Reply-To: Your message of "Fri, 21 Dec 2001 00:58:35 +1100."
             <20011221005726.Q884-100000@gamplex.bde.org> 
Date: Thu, 20 Dec 2001 20:29:32 +0100
Message-ID: <667.1008876572@critter.freebsd.dk>
From: Poul-Henning Kamp <phk@critter.freebsd.dk>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

In message <20011221005726.Q884-100000@gamplex.bde.org>, Bruce Evans writes:
>On Wed, 19 Dec 2001, Peter Wemm wrote:
>
>> peter       2001/12/19 21:29:59 PST
>>
>>   Modified files:
>>     sys/alpha/alpha      pmap.c
>>     sys/i386/i386        pmap.c
>>     sys/ia64/ia64        pmap.c
>>   Log:
>>   Replace a bunch of:
>>         for (pv = TAILQ_FIRST(&m->md.pv_list);
>>                  pv;
>>                  pv = TAILQ_NEXT(pv, pv_list)) {
>>   with:
>>         TAILQ_FOREACH(pv, &m->md.pv_list, pv_list) {
>>
>>   Revision  Changes    Path
>>   1.79      +9 -28     src/sys/alpha/alpha/pmap.c
>>   1.301     +6 -20     src/sys/i386/i386/pmap.c
>>   1.41      +10 -30    src/sys/ia64/ia64/pmap.c
>
>This is a regression IMO.  Please write C programs in something
>resembling C.

This is an improvement IMO.  Please use whatever means we have to
improve readability of our source code.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message