From owner-svn-src-head@freebsd.org Fri Dec 30 13:39:32 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32638C97AA5; Fri, 30 Dec 2016 13:39:32 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EF3CC13B1; Fri, 30 Dec 2016 13:39:31 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io0-x244.google.com with SMTP id n85so21900422ioi.1; Fri, 30 Dec 2016 05:39:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=JrMUF5xdjCdh9hGG6gSG1jJJCjMdrKHg6fTFe0yNotg=; b=qPfxCPzyfd49rxuwWZ+OXoBwMt0GThknd+Xnjxe8iLzs1MvlAgK0c9ULYpiYQyVNtb BwBXA+hXqNFhxQSnSQa3vE+7NNfQZg8jHymdQh3IzJrUP/phE5qPXvmVq4FZV3BwHEVE pK/HqwZ25IO5clFoRlhbWoObwJlEpOsFHGLWgavBB4Zi0g9yO75rz49V7ubQWYAaj2Ml zWTjqTANGWWBMDPwCXvZZl6paw6IgbLlG2aTt5AZeTE0IL09PZOBKsjSCinn/2DQxko/ 6XaJcfxmOmUfn1GV39zhry2oGZ/IE6r+0NFnyRFMv6R0/3We8qXC6YCwj7BZsaULK8b6 cTcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=JrMUF5xdjCdh9hGG6gSG1jJJCjMdrKHg6fTFe0yNotg=; b=NXPZyMPRHcpCfjwQKUQVoPMOStZsFzj3aZCIB4NxN/6Tbkge+KCevtpg3Wi1vdvafm nSE9xwqS2/kU7iP+jo2SyvD2Xlu0T7x6tXju4PSigNCGxS96WTIzf2a9firgAWivJ0pb oPTotFC5KkE97bopYmZ22j6KJqB/fHTyfnmwXvDLgykAnfDJeEfnmeTBD+iPdR06uXhn CZZEkg5zVliY4DqYAwO1D928ft/xRrIqPGGlqzU7x4+ivRZPB2JINdlmFZn/Vom360ST FufK/G2js09FEjsHEX4zxP4YPtY7IGjhh8zDfXXdKChcaao+YSEAIVMZ+2tkhxQBNW1y TlEw== X-Gm-Message-State: AIkVDXI+0EMzE4WWsvHQ3HCBt2lNW+aSBAPcNnfnKlKoKI4VcyeCB5NCnbgNb9tdUFgUtT34R4FjabtZAoSAHA== X-Received: by 10.107.23.134 with SMTP id 128mr31845801iox.162.1483105170113; Fri, 30 Dec 2016 05:39:30 -0800 (PST) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.175.133 with HTTP; Fri, 30 Dec 2016 05:39:09 -0800 (PST) In-Reply-To: <1A7F0D4F-1F4D-4885-B7E9-F764D4FA72BF@panasas.com> References: <201612292130.uBTLUqus011628@repo.freebsd.org> <1A7F0D4F-1F4D-4885-B7E9-F764D4FA72BF@panasas.com> From: Ed Maste Date: Fri, 30 Dec 2016 08:39:09 -0500 X-Google-Sender-Auth: APl1142Gifjx5M41Mh1GFn15cbY Message-ID: Subject: Re: svn commit: r310789 - head/lib/libpam/static_libpam To: Ravi Pokala Cc: Alexander Kabaev , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2016 13:39:32 -0000 On 29 December 2016 at 19:59, Ravi Pokala wrote: > > I'm a little confused - the original version had to have had a compile-on= ly step to generate the object first, before running the link-only operatio= n against the object. The new code replaces the link-only operation with a = compile+link operation. Shouldn't the pre-existing compile-only operation b= e removed, since the new compile+link operation supersedes it? Hi Ravi, This change: >> - ${LD} -o ${.TARGET} -r --whole-archive ${.ALLSRC} >> + ${CC} -nostdlib ${CFLAGS} -o ${.TARGET} -r -Wl,--whole-archive ${.= ALLSRC} is not actually compiling, it's just invoking the compiler driver to in turn invoke the linker. The input in ${.ALLSRC} is still a collection of object files.