Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 Jan 2008 17:18:40 +0100 (CET)
From:      Ed Schouten <ed@fxq.nl>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/120049: [Patch] cad/magic: don't use sgtty
Message-ID:  <20080127161840.14CA31CC44@palm.hoeg.nl>
Resent-Message-ID: <200801271620.m0RGK1Pb017058@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         120049
>Category:       ports
>Synopsis:       [Patch] cad/magic: don't use sgtty
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 27 16:20:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Ed Schouten
>Release:        FreeBSD 6.3-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD palm.hoeg.nl 6.3-PRERELEASE FreeBSD 6.3-PRERELEASE #0: Wed Dec 19 16:07:46 CET 2007 ed@palm.hoeg.nl:/usr/obj/usr/src/sys/PALM i386
>Description:
The cad/magic port still includes sgtty.h, while it doesn't use
anything that's in there. We'd better not include sgtty.h, because this
will cause things to break in the future.
>How-To-Repeat:
>Fix:
Just empty magsgtty.h. That header file chooses whether we want sgtty or
termios, but there is no need to include any of them.

--- cad/magic/Makefile	2007-05-19 22:00:34.000000000 +0200
+++ cad/magic/Makefile	2008-01-27 17:11:14.000000000 +0100
@@ -35,6 +35,7 @@
 		 s|include.*<varargs\.h>|include <stdarg\.h>|'
 	@${FIND} ${WRKSRC} -name "Makefile" | ${XARGS} ${REINPLACE_CMD} -e \
 		's|make |\$$\{MAKE\} |g'
+	@${ECHO} > ${WRKSRC}/misc/magsgtty.h
 
 do-configure:
 	@cd ${WRKSRC} && ${WRKSRC}/scripts/makedbh \
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080127161840.14CA31CC44>