From owner-freebsd-net@FreeBSD.ORG  Wed Feb 11 08:38:26 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 879A07BF
 for <freebsd-net@freebsd.org>; Wed, 11 Feb 2015 08:38:26 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 650D0CC1
 for <freebsd-net@freebsd.org>; Wed, 11 Feb 2015 08:38:26 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t1B8cQDm056803
 for <freebsd-net@freebsd.org>; Wed, 11 Feb 2015 08:38:26 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1B8cQNQ056802;
 Wed, 11 Feb 2015 08:38:26 GMT (envelope-from root)
Date: Wed, 11 Feb 2015 08:38:26 +0000
To: freebsd-net@freebsd.org
From: "rwatson (Robert Watson)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Updated] D1809: [sockbuf] Don't expose lock details
 when isn't needed
Message-ID: <a6e0095be3e65d85d62255f979abae8c@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1809: [sockbuf] Don't expose lock details when isn't needed
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-ejmjsmhpyau7otpbjnc6>
X-Phabricator-To: <PHID-USER-22avn2hssqzufmcg2crf>
X-Phabricator-To: <PHID-USER-mqlw6f5jjiqhbs4co7yd>
X-Phabricator-To: <PHID-USER-nb2boxugvmpo7syia5md>
X-Phabricator-To: <PHID-USER-s22ldiy33wseno7vfmzs>
X-Phabricator-To: <PHID-USER-xs5piezwnsa6epounp3t>
X-Phabricator-Cc: <PHID-USER-mhzsgq7klbzjcspjzvus>
X-Phabricator-Cc: <PHID-MLST-c3bj6mfydtlqmuethodc>
In-Reply-To: <differential-rev-PHID-DREV-itcsjouioqxprcrqy7hw-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-itcsjouioqxprcrqy7hw-req@FreeBSD.org>
Thread-Index: ZDUyNzQ5ZWQxMTRmZDFiNGM0NTM4Yzk5MDEwIFTbFQI=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-reviewers>, <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Feb 2015 08:38:26 -0000

rwatson added a comment.

Seems reasonable. I'm slightly surprised that any code other than sbwait() actually implements the sleep on sb_acc, and wonder if either a use of abstraction improvement, or an actual abstraction improvement, is needed to fix t4_ddp.c.

REVISION DETAIL
  https://reviews.freebsd.org/D1809

To: davide, kmacy, np, rrs, lstewart, rwatson
Cc: julian, freebsd-net