From owner-freebsd-current Tue Mar 6 8:27:22 2001 Delivered-To: freebsd-current@freebsd.org Received: from critter.freebsd.dk (flutter.freebsd.dk [212.242.40.147]) by hub.freebsd.org (Postfix) with ESMTP id C4BE337B718; Tue, 6 Mar 2001 08:27:18 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.1/8.11.1) with ESMTP id f26GRbB09379; Tue, 6 Mar 2001 17:27:37 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Maxim Sobolev Cc: Warner Losh , igorr@crosswinds.net, freebsd-current@FreeBSD.ORG Subject: Re: Correct size of kinfo_proc In-Reply-To: Your message of "Tue, 06 Mar 2001 18:23:29 +0200." <3AA50F01.6560C34A@FreeBSD.org> Date: Tue, 06 Mar 2001 17:27:37 +0100 Message-ID: <9377.983896057@critter> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <3AA50F01.6560C34A@FreeBSD.org>, Maxim Sobolev writes: >Warner Losh wrote: > >> In message <20010228161009.B14235@linux.rainbow> Igor Robul writes: >> : On Wed, Feb 28, 2001 at 03:00:48PM +0200, Maxim Sobolev wrote: >> : > Hi Poul, >> : > >> : > In revision 1.31 of src/sys/sys/user.h you have added new ki_layout field to >> : > kinfo_proc structure, but forgot to increase KINFO_PROC_SIZE from 644 to 648. >> : > Please correct. >> : Why don't use sizeof() insead of hardcoding numbers? >> >> Because KINFO_PROC_SIZE is part of the ABI. Changes to its size are >> always wrong, in that they break the ABI. The checks are there to >> tell us when the ABI has been broken. > >Well, we are now well informed about this, could we just fix sys/sys/user.h to match >relity (credit goes to phk for broking it and ignoring my posts completely)? I've been kind of waiting for -current to actually work again. I hate commiting to -current when it's börked. Yes, fix it in for now, or better, do the right thing with version numbers. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message