From owner-svn-src-all@freebsd.org Tue May 8 22:10:34 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B79F8FCBDF2; Tue, 8 May 2018 22:10:33 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pg0-x22a.google.com (mail-pg0-x22a.google.com [IPv6:2607:f8b0:400e:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 275417DA44; Tue, 8 May 2018 22:10:33 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pg0-x22a.google.com with SMTP id k11-v6so20630836pgo.10; Tue, 08 May 2018 15:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cE6Eq1/MSBgMmI187ZK8UTy8GYDArZCAY5QndYADJR4=; b=oKrlkYhy5iXu52SoQJEOjzzQO+BzQeCqJN4ijzk2Ii6O99dVgnWS4JK8xrXLWKUM66 Ua59GMt93jckfnM6j6uvuY8/t48wYMVQ8KJv02vPJ21K1cGMncGrz6qxIaNkqjlxyo2E waEmVj+YJru3QK++n+gfT9lzzZDChVzBmXM4CH67rsZdsqRZeldcksUDvPh1WkY0T99g 3479C03jBFnhBypSwwPl+pv/MrorRIyfvrop0RJZBTF112tVe2l6T1+1mN0urtviMSgr ZyhoCn+YUJZgf3wfkymDpn2yRkajgxKy6ksljgWR6w51jIOVjmZ31llJtsP3yZGNaz/H Be/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=cE6Eq1/MSBgMmI187ZK8UTy8GYDArZCAY5QndYADJR4=; b=aZip+pSo8VakSViYiKhyxLnYY8euoaF8D2LLxDGzS8DCifAh8TZ8lpXGZ+O3KSi23o H0dAJV5Bu8UxPCRmlAY5622t6N7QDD29QUp7mifjsYMvtpLqGpFSRWTbwScJXyg9uvoa cJlhnSTzEPiFM0owNUp2xYcFE+i9NLvphx46QeD9J0xl9DmyQmwslNsMMrzOg0Wy8lNc CnuUIU1FFVdtPpI9hPbml1/dNDB5qX2+pjfC1QtihXrE7WLh8E+ECuj8S0gmrmLN8BOt Yt92kjKCfGQSBJOT7f9U7ud36dbADBg6wfEFk+87u/EGxgu2iwdw42EYOTZoDHV9XiTP 6m5g== X-Gm-Message-State: ALQs6tDikO8Y6430ddtq81/riAhKddzgi0sTAJSydRFTY3c9i9noKSze wx0tyFhjdqQ/cys+psYkOy1yHg== X-Google-Smtp-Source: AB8JxZpUKh/iQ/3gdI+6UTrYhUXiefXiom2QE5ztLnFiUPr/+rNPXt7Ado0KuGTJou9IXFGdKdBMwQ== X-Received: by 2002:a65:60d1:: with SMTP id r17-v6mr29650215pgv.410.1525817431965; Tue, 08 May 2018 15:10:31 -0700 (PDT) Received: from raichu (toroon0560w-lp130-04-184-145-252-229.dsl.bell.ca. [184.145.252.229]) by smtp.gmail.com with ESMTPSA id t14sm552012pfh.109.2018.05.08.15.10.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 May 2018 15:10:31 -0700 (PDT) Sender: Mark Johnston Date: Tue, 8 May 2018 18:10:25 -0400 From: Mark Johnston To: Matt Macy Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333345 - head/sys/dev/e1000 Message-ID: <20180508221025.GA4249@raichu> References: <201805080139.w481djMX062724@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201805080139.w481djMX062724@repo.freebsd.org> User-Agent: Mutt/1.9.5 (2018-04-13) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 22:10:34 -0000 On Tue, May 08, 2018 at 01:39:45AM +0000, Matt Macy wrote: > Author: mmacy > Date: Tue May 8 01:39:45 2018 > New Revision: 333345 > URL: https://svnweb.freebsd.org/changeset/base/333345 > > Log: > Sleep rather than spin in e1000 when doing long running config operations. > > With r333218 it is now possible for drivers to use an sx lock and thus sleep while > waiting on long running operations rather than DELAY(). > > Reported by: gallatin > Reviewed by: sbruno > Approved by: sbruno > MFC after: 1 month > Sponsored by: Limelight Networks > Differential Revision: https://reviews.freebsd.org/D14984 I'm getting a panic during boot with this change: "unknown mac type d". It occurs while the driver is attaching to: em0@pci0:1:0:0: class=0x020000 card=0x7044103c chip=0x105e8086 rev=0x06 hdr=0x00 vendor = 'Intel Corporation' device = '82571EB Gigabit Ethernet Controller' class = network subclass = ethernet