From owner-freebsd-hackers@FreeBSD.ORG Tue Oct 5 14:49:16 2004 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF7B216A4CE for ; Tue, 5 Oct 2004 14:49:16 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id CF2DF43D2D for ; Tue, 5 Oct 2004 14:49:16 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i95EsF6L012537; Tue, 5 Oct 2004 07:54:15 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i95EsFJG012536; Tue, 5 Oct 2004 07:54:15 -0700 Date: Tue, 5 Oct 2004 07:54:15 -0700 From: Brooks Davis To: Christopher Nehren Message-ID: <20041005145415.GB2520@odin.ac.hmc.edu> References: <200410042335.i94NZDaL098088@repoman.freebsd.org> <1096943605.1096.26.camel@prophecy.dyndns.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OwLcNYc0lM97+oe1" Content-Disposition: inline In-Reply-To: <1096943605.1096.26.camel@prophecy.dyndns.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: FreeBSD Hackers List Subject: Re: cvs commit: src/usr.sbin/newsyslog newsyslog.8 newsyslog.c X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2004 14:49:17 -0000 --OwLcNYc0lM97+oe1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 04, 2004 at 10:33:25PM -0400, Christopher Nehren wrote: > On Mon, 2004-10-04 at 23:35 +0000, Brooks Davis wrote: > > brooks 2004-10-04 23:35:13 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > usr.sbin/newsyslog newsyslog.8 newsyslog.c=20 > > Log: > > Add a new -d argument which is used to specify an alternate root for = log > > files similar to DESTDIR in the BSD make process. This only affects = log > > file paths not config file (-f) or archive directory (-a) paths. >=20 > Excellent idea. This will cut down on a lot of verbosity in the > newsyslog.conf file. However, perhaps the accompanying patch is a better > implementation. It allows both relative and absolute path names to be > listed, so that logs which are stored in a chroot'd environment (think > BIND 9) can be specified along with logs specified with the -d option. > I'll admit right now that my C is nothing near as good as I'd like it to > be (though I have been reading my Deitel book), but I have tested this > and it does what I want it to do. This is not my intent. If anything, the opposite should be implemented because you'll get non-sensical paths from relative paths otherwise. Are relative paths currently supported? They don't seem to make much sense, though maybe on the command line. My initial goal was to make it possiable to use newsyslog to create log files in the src/etc/Makefile distribution target rather the current method which hard codes a copy of the information stored in newsyslog.conf in the Makefile. > Also, while I'm here, is there any plan to port this to RELENG_5? Yes, I plan MFC at some point. I doubt it will be done for 5.3 at this point. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --OwLcNYc0lM97+oe1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBYrWWXY6L6fI4GtQRAuFfAJwPRtkvzEgAaMdDFS7tikewmeqa3gCeKNtE ctZOg4OCVsGw2avK2ZBVFHk= =pGOc -----END PGP SIGNATURE----- --OwLcNYc0lM97+oe1--