Date: Sat, 7 Apr 2012 14:35:06 GMT From: Thomas Zander <thomas.e.zander@googlemail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/166729: ogmtools should use the OPTIONS framework Message-ID: <201204071435.q37EZ6ZG042585@red.freebsd.org> Resent-Message-ID: <201204071440.q37Ee500089775@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 166729
>Category: ports
>Synopsis: ogmtools should use the OPTIONS framework
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Apr 07 14:40:05 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Thomas Zander
>Release: FreeBSD 8.3-PRERELEASE
>Organization:
>Environment:
>Description:
ogmtools still performs opportunistic detection of locally installed packages to determine its dependencies.
This is discouraged nowadays since the OPTIONS framework expects the user to explicitly state what he wants.
>How-To-Repeat:
>Fix:
Attached patch introduces OPTIONS for the (so far) only dependency variable WITH_DVDREAD.
Patch attached with submission follows:
diff -ruN /usr/ports/multimedia/ogmtools/Makefile ogmtools/Makefile
--- /usr/ports/multimedia/ogmtools/Makefile 2012-01-17 15:35:16.000000000 +0100
+++ ogmtools/Makefile 2012-04-07 16:13:49.811735043 +0200
@@ -48,9 +48,7 @@
.include <bsd.port.pre.mk>
-.if exists(${LOCALBASE}/lib/libdvdread.so.4)
-WITH_DVDREAD=yes
-.endif
+OPTIONS= DVDREAD "DVD title chapter extraction via libdvdread" on
.ifdef(WITH_DVDREAD)
LIB_DEPENDS+= dvdread.4:${PORTSDIR}/multimedia/libdvdread
@@ -66,9 +64,4 @@
PLIST_SUB+= WITH_DVDREAD="@comment "
.endif
-pre-everything::
-.ifndef(WITH_DVDREAD)
- @${ECHO_MSG} "===> Define WITH_DVDREAD in order to be able to 'Extract chapter information from DVDs'"
-.endif
-
.include <bsd.port.post.mk>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201204071435.q37EZ6ZG042585>