Date: Sat, 1 Nov 2008 16:24:12 GMT From: Sergei Golyashov <svvord@spline-studio.ru> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/128522: Patch for graphics/lcms to add python binding Message-ID: <200811011624.mA1GOCUj064582@www.freebsd.org> Resent-Message-ID: <200811011630.mA1GU8Zn022772@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 128522
>Category: ports
>Synopsis: Patch for graphics/lcms to add python binding
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Sat Nov 01 16:30:08 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Sergei Golyashov
>Release: FreeBSD 7.0-STABLE i386
>Organization:
Spline Ltd.
>Environment:
FreeBSD crush.dony 7.0-STABLE FreeBSD 7.0-STABLE #2: Sat Aug 23 03:58:51 VLAST 2008 crush@crush.dony:/usr/obj/usr/src/sys/CRUSH i386
>Description:
Python binding present in lcms but not installed by port. This patch corrects the given omission.
Python binding for lcms is necessary for some programs. For example sK1.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
--- Makefile.old 2008-11-02 00:33:37.000000000 +1000
+++ Makefile 2008-11-02 01:42:28.000000000 +1000
@@ -7,7 +7,7 @@
PORTNAME= lcms
PORTVERSION= 1.17
-PORTREVISION= 0
+PORTREVISION= 1
PORTEPOCH= 1
CATEGORIES= graphics
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} \
@@ -23,9 +23,11 @@
CPPFLAGS="${CPPFLAGS} -I${LOCALBASE}/include" \
LDFLAGS="${LDFLAGS} -L${LOCALBASE}/lib"
USE_LDCONFIG= yes
+USE_PYTHON= yes
OPTIONS= TIFFICC "Build color profile applier for tiff" off \
- JPEGICC "Build color profile applier for JPEG" off
+ JPEGICC "Build color profile applier for JPEG" off \
+ PYTHON "Build with python extension" off
.include <bsd.port.pre.mk>
@@ -47,6 +49,14 @@
PLIST_SUB+= JPEGICC="@comment "
.endif
+.if defined(WITH_PYTHON)
+BUILD_DEPENDS+= python:${PORTSDIR}/lang/python
+PLIST_SUB+= PYTHON=""
+CONFIGURE_ARGS= --with-python
+.else
+PLIST_SUB+= PYTHON="@comment "
+.endif
+
post-patch:
@${REINPLACE_CMD} -e \
's|^SUBDIRS =.*$$|SUBDIRS = src include|g' ${WRKSRC}/Makefile.in
@@ -72,6 +82,11 @@
${MAKE_FLAGS} Makefile all install)
.endif
+.if defined(WITH_PYTHON)
+ @(cd ${WRKSRC}/python && ${SETENV} ${MAKE_ENV} ${MAKE} \
+ ${MAKE_FLAGS} Makefile all install)
+.endif
+
post-build test:
cd ${WRKSRC}/testbed && ${SETENV} ${MAKE_ENV} ${MAKE} check
--- pkg-plist.old 2008-11-02 00:33:37.000000000 +1000
+++ pkg-plist 2008-11-02 00:39:48.000000000 +1000
@@ -1,6 +1,10 @@
%%JPEGICC%%bin/jpegicc
%%TIFFICC%%bin/tiffdiff
%%TIFFICC%%bin/tifficc
+%%PYTHON%%%%PYTHON_SITELIBDIR%%/_lcms.so
+%%PYTHON%%%%PYTHON_SITELIBDIR%%/_lcms.la
+%%PYTHON%%%%PYTHON_SITELIBDIR%%/_lcms.a
+%%PYTHON%%%%PYTHON_SITELIBDIR%%/lcms.py
include/icc34.h
include/lcms.h
lib/liblcms.a
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200811011624.mA1GOCUj064582>